Issue 1117393002: win: Don't log wide strings via path.value().c_str()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1117393002: win: Don't log wide strings via path.value().c_str() (Closed)

Created:
5 years, 7 months ago by scottmg

Modified:
5 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@settings-access

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win: Don't log wide strings via path.value().c_str() At the moment the LOGs print something unhelpful like: [19912:21888:20150501,145958.098:ERROR file_io_win.cc:122] CreateFile 000000C9F8FDE7F0: The system cannot find the file specified. (0x2) (where the hex string ought to be a file name) R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/d8713a576bfd633c4252e17124f4813e9b5a3116

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
M	client/crash_report_database_win.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	snapshot/crashpad_info_client_options_test.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	util/file/file_io_win.cc	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

scottmg

5 years, 7 months ago (2015-05-01 22:49:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d8713a576bfd633c4252e17124f4813e9b5a3116 (presubmit successful).