win: Don't log wide strings via path.value().c_str()

util/file/file_io_win.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/file/file_io.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
+#include "base/strings/utf_string_conversions.h"
 
 namespace {
 
 bool IsSocketHandle(HANDLE file) {
   if (GetFileType(file) == FILE_TYPE_PIPE) {
     // FILE_TYPE_PIPE means that it's a socket, a named pipe, or an anonymous
     // pipe. If we are unable to retrieve the pipe information, we know it's a
     // socket.
     return !GetNamedPipeInfo(file, NULL, NULL, NULL, NULL);
   }
@@ skipping 22 matching lines @@
       disposition = CREATE_NEW;
       break;
   }
   HANDLE file = CreateFile(path.value().c_str(),
                            access,
                            FILE_SHARE_READ | FILE_SHARE_WRITE,
                            nullptr,
                            disposition,
                            FILE_ATTRIBUTE_NORMAL,
                            nullptr);
-  PLOG_IF(ERROR, file == INVALID_HANDLE_VALUE) << "CreateFile "
-                                               << path.value().c_str();
+  PLOG_IF(ERROR, file == INVALID_HANDLE_VALUE)
+      << "CreateFile " << base::UTF16ToUTF8(path.value());
   return file;
 }
 
 }  // namespace
 
 // TODO(scottmg): Handle > DWORD sized writes if necessary.
 
 ssize_t ReadFile(FileHandle file, void* buffer, size_t size) {
   DCHECK(!IsSocketHandle(file));
   DWORD size_dword = base::checked_cast<DWORD>(size);
@@ skipping 38 matching lines @@
 }
 
 FileHandle LoggingOpenFileForRead(const base::FilePath& path) {
   HANDLE file = CreateFile(path.value().c_str(),
                            GENERIC_READ,
                            FILE_SHARE_READ | FILE_SHARE_WRITE,
                            nullptr,
                            OPEN_EXISTING,
                            0,
                            nullptr);
-  PLOG_IF(ERROR, file == INVALID_HANDLE_VALUE) << "CreateFile "
-                                               << path.value().c_str();
+  PLOG_IF(ERROR, file == INVALID_HANDLE_VALUE)
+      << "CreateFile " << base::UTF16ToUTF8(path.value());
   return file;
 }
 
 FileHandle LoggingOpenFileForWrite(const base::FilePath& path,
                                    FileWriteMode mode,
                                    FilePermissions permissions) {
   return LoggingOpenFileForOutput(GENERIC_WRITE, path, mode, permissions);
 }
 
 FileHandle LoggingOpenFileForReadAndWrite(const base::FilePath& path,
@@ skipping 68 matching lines @@
   return true;
 }
 
 bool LoggingCloseFile(FileHandle file) {
   BOOL rv = CloseHandle(file);
   PLOG_IF(ERROR, !rv) << "CloseHandle";
   return rv;
 }
 
 }  // namespace crashpad