Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: client/crash_report_database_win.cc

Issue 1117393002: win: Don't log wide strings via path.value().c_str() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@settings-access
Patch Set: just convert at callsite instead of global std::operator<< Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | snapshot/crashpad_info_client_options_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crash_report_database_win.cc
diff --git a/client/crash_report_database_win.cc b/client/crash_report_database_win.cc
index ff120e8a400114952cacedc56d7b734c1eaec2f6..d85c9492198b0fdd48f108da2960b316a35b6c2a 100644
--- a/client/crash_report_database_win.cc
+++ b/client/crash_report_database_win.cc
@@ -446,7 +446,7 @@ void Metadata::Write() {
const base::FilePath& path = report.file_path;
if (path.DirName() != report_dir_) {
LOG(ERROR) << path.value().c_str() << " expected to start with "
- << report_dir_.value().c_str();
+ << base::UTF16ToUTF8(report_dir_.value());
return;
}
records.push_back(MetadataFileReportRecord(report, &string_table));
@@ -626,7 +626,8 @@ OperationStatus CrashReportDatabaseWin::ErrorWritingCrashReport(
// We failed to write, so remove the dump file. There's no entry in the
// metadata table yet.
if (!DeleteFile(scoped_report->path.value().c_str())) {
- PLOG(ERROR) << "DeleteFile " << scoped_report->path.value().c_str();
+ PLOG(ERROR) << "DeleteFile "
+ << base::UTF16ToUTF8(scoped_report->path.value());
return CrashReportDatabase::kFileSystemError;
}
« no previous file with comments | « no previous file | snapshot/crashpad_info_client_options_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698