snapshot/crashpad_info_client_options_test.cc - Issue 1117393002: win: Don't log wide strings via path.value().c_str()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/crashpad_info_client_options_test.cc

Issue 1117393002: win: Don't log wide strings via path.value().c_str() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@settings-access

Patch Set: just convert at callsite instead of global std::operator<< Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/crashpad_info_client_options_test.cc

diff --git a/snapshot/crashpad_info_client_options_test.cc b/snapshot/crashpad_info_client_options_test.cc

index 2b13b6b2223b7f2fe6319e3678273a053d65a310..acdc3257c58de96f07ee359a4f68d258439fa81c 100644

--- a/snapshot/crashpad_info_client_options_test.cc

+++ b/snapshot/crashpad_info_client_options_test.cc

@@ -15,6 +15,7 @@

#include "snapshot/crashpad_info_client_options.h"

#include "base/files/file_path.h"

+#include "base/strings/utf_string_conversions.h"

#include "build/build_config.h"

#include "client/crashpad_info.h"

#include "gtest/gtest.h"

@@ -167,9 +168,9 @@ TEST(CrashpadInfoClientOptions, TwoModules) {

<< dlerror();

#elif defined(OS_WIN)

ScopedDlHandle dl_handle(LoadLibrary(module_path.value().c_str()));

- ASSERT_TRUE(dl_handle.valid()) << "LoadLibrary "

- << module_path.value().c_str() << ": "

- << ErrorMessage();

+ ASSERT_TRUE(dl_handle.valid())

+ << "LoadLibrary " << base::UTF16ToUTF8(module_path.value()) << ": "

+ << ErrorMessage();

#else

#error Port.

#endif // OS_MACOSX

« no previous file with comments | « client/crash_report_database_win.cc ('k') | util/file/file_io_win.cc » ('j') | no next file with comments »