Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1116843002: v8::Isolate* should be the first parameter (Closed)

Created:
5 years, 7 months ago by Shiva Samsung
Modified:
5 years, 7 months ago
Reviewers:
haraken, vivekg
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

v8::Isolate* should be the first parameter As v8::isolate is not a optional argument anymore, move isolate to first argumnet of methods in bindings BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194968

Patch Set 1 #

Patch Set 2 : Fix Compilation Error in merging of v8::Isolate* should be the first parameter patch #

Patch Set 3 : Removed Warnings message recevied in V8TestObject.cpp for the patch v8::Isolate* should be the firs… #

Patch Set 4 : Fixed Mac compilation error for v8::Isolate* should be the first parameter patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M Source/bindings/core/v8/PostMessage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/SerializedScriptValueFactory.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 1 3 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValueTest.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (10 generated)
Shiva Samsung
PTAL? Thanks!
5 years, 7 months ago (2015-04-30 03:53:20 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-30 03:55:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116843002/1
5 years, 7 months ago (2015-04-30 03:56:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/34336)
5 years, 7 months ago (2015-04-30 04:04:50 UTC) #7
Shiva Samsung
PTAL? Fixed the compilation error occurred due to merging of patch with the latest code. ...
5 years, 7 months ago (2015-05-01 09:55:29 UTC) #8
haraken
LGTM
5 years, 7 months ago (2015-05-01 09:57:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116843002/20001
5 years, 7 months ago (2015-05-01 09:59:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/32525)
5 years, 7 months ago (2015-05-01 10:06:39 UTC) #13
Shiva Samsung
PTAL? Removed warnings message received due to changes required in V8TestObject.cpp .
5 years, 7 months ago (2015-05-01 11:35:24 UTC) #14
haraken
LGTM
5 years, 7 months ago (2015-05-01 12:26:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116843002/40001
5 years, 7 months ago (2015-05-02 13:03:45 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/43732)
5 years, 7 months ago (2015-05-02 13:19:25 UTC) #19
Shiva Samsung
PTAL? Mac compilation error has been fixed.
5 years, 7 months ago (2015-05-06 05:24:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116843002/60001
5 years, 7 months ago (2015-05-06 08:21:50 UTC) #23
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 10:31:43 UTC) #24
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194968

Powered by Google App Engine
This is Rietveld 408576698