Source/modules/indexeddb/IDBObjectStore.cpp - Issue 1116843002: v8::Isolate* should be the first parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBObjectStore.cpp

Issue 1116843002: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed Mac compilation error for v8::Isolate* should be the first parameter patch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/indexeddb/IDBObjectStore.cpp

diff --git a/Source/modules/indexeddb/IDBObjectStore.cpp b/Source/modules/indexeddb/IDBObjectStore.cpp

index 509f253748c7cd3aebee92139a9fe627c43ce26a..6eda7b0af1d274b7b62f854dc228a05a31d487c1 100644

--- a/Source/modules/indexeddb/IDBObjectStore.cpp

+++ b/Source/modules/indexeddb/IDBObjectStore.cpp

@@ -180,7 +180,7 @@ IDBRequest* IDBObjectStore::put(ScriptState* scriptState, WebIDBPutMode putMode,

}

Vector<WebBlobInfo> blobInfo;

- RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValueFactory::instance().create(value, &blobInfo, exceptionState, scriptState->isolate());

+ RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValueFactory::instance().create(scriptState->isolate(), value, &blobInfo, exceptionState);

if (exceptionState.hadException())

return 0;

« no previous file with comments | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »