Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: Source/bindings/core/v8/SerializedScriptValueTest.cpp

Issue 1116843002: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed Mac compilation error for v8::Isolate* should be the first parameter patch Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/SerializedScriptValueTest.cpp
diff --git a/Source/bindings/core/v8/SerializedScriptValueTest.cpp b/Source/bindings/core/v8/SerializedScriptValueTest.cpp
index b29ba9a5784dc487c98d24a83e268a883d55181e..700d4f7a66bb20b2577f7068fa4c884d5bf64b7e 100644
--- a/Source/bindings/core/v8/SerializedScriptValueTest.cpp
+++ b/Source/bindings/core/v8/SerializedScriptValueTest.cpp
@@ -42,7 +42,7 @@ TEST_F(SerializedScriptValueTest, UserSelectedFile)
v8::Local<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());
RefPtr<SerializedScriptValue> serializedScriptValue =
- SerializedScriptValueFactory::instance().create(v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION, isolate());
+ SerializedScriptValueFactory::instance().create(isolate(), v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION);
v8::Local<v8::Value> v8File = serializedScriptValue->deserialize(isolate());
ASSERT_TRUE(V8File::hasInstance(v8File, isolate()));
@@ -62,7 +62,7 @@ TEST_F(SerializedScriptValueTest, FileConstructorFile)
v8::Local<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());
RefPtr<SerializedScriptValue> serializedScriptValue =
- SerializedScriptValueFactory::instance().create(v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION, isolate());
+ SerializedScriptValueFactory::instance().create(isolate(), v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION);
v8::Local<v8::Value> v8File = serializedScriptValue->deserialize(isolate());
ASSERT_TRUE(V8File::hasInstance(v8File, isolate()));
« no previous file with comments | « Source/bindings/core/v8/SerializedScriptValueFactory.cpp ('k') | Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698