Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 1116843002: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed Mac compilation error for v8::Isolate* should be the first parameter patch Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 targetOriginArgIndex = 2; 203 targetOriginArgIndex = 2;
204 transferablesArgIndex = 1; 204 transferablesArgIndex = 1;
205 } 205 }
206 if (!SerializedScriptValue::extractTransferables(info.GetIsolate(), info [transferablesArgIndex], transferablesArgIndex, portArray, arrayBufferArray, exc eptionState)) { 206 if (!SerializedScriptValue::extractTransferables(info.GetIsolate(), info [transferablesArgIndex], transferablesArgIndex, portArray, arrayBufferArray, exc eptionState)) {
207 exceptionState.throwIfNeeded(); 207 exceptionState.throwIfNeeded();
208 return; 208 return;
209 } 209 }
210 } 210 }
211 TOSTRING_VOID(V8StringResource<TreatNullAndUndefinedAsNullString>, targetOri gin, info[targetOriginArgIndex]); 211 TOSTRING_VOID(V8StringResource<TreatNullAndUndefinedAsNullString>, targetOri gin, info[targetOriginArgIndex]);
212 212
213 RefPtr<SerializedScriptValue> message = SerializedScriptValueFactory::instan ce().create(info[0], &portArray, &arrayBufferArray, exceptionState, info.GetIsol ate()); 213 RefPtr<SerializedScriptValue> message = SerializedScriptValueFactory::instan ce().create(info.GetIsolate(), info[0], &portArray, &arrayBufferArray, exception State);
214 if (exceptionState.throwIfNeeded()) 214 if (exceptionState.throwIfNeeded())
215 return; 215 return;
216 216
217 window->postMessage(message.release(), &portArray, targetOrigin, source, exc eptionState); 217 window->postMessage(message.release(), &portArray, targetOrigin, source, exc eptionState);
218 exceptionState.throwIfNeeded(); 218 exceptionState.throwIfNeeded();
219 } 219 }
220 220
221 // FIXME(fqian): returning string is cheating, and we should 221 // FIXME(fqian): returning string is cheating, and we should
222 // fix this by calling toString function on the receiver. 222 // fix this by calling toString function on the receiver.
223 // However, V8 implements toString in JavaScript, which requires 223 // However, V8 implements toString in JavaScript, which requires
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 { 345 {
346 return securityCheck(host); 346 return securityCheck(host);
347 } 347 }
348 348
349 bool V8Window::indexedSecurityCheckCustom(v8::Local<v8::Object> host, uint32_t i ndex, v8::AccessType type, v8::Local<v8::Value>) 349 bool V8Window::indexedSecurityCheckCustom(v8::Local<v8::Object> host, uint32_t i ndex, v8::AccessType type, v8::Local<v8::Value>)
350 { 350 {
351 return securityCheck(host); 351 return securityCheck(host);
352 } 352 }
353 353
354 } // namespace blink 354 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698