Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 11144023: cc: Store tiles, painters, tiling data in scoped_ptr (Closed)

Created:
8 years, 2 months ago by enne (OOO)
Modified:
8 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, tfarina
Visibility:
Public.

Description

cc: Store tiles, painters, tiling data in scoped_ptr BUG=154451 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161994

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -133 lines) Patch
M cc/bitmap_canvas_layer_texture_updater.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M cc/bitmap_canvas_layer_texture_updater.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M cc/bitmap_skpicture_canvas_layer_texture_updater.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M cc/bitmap_skpicture_canvas_layer_texture_updater.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M cc/caching_bitmap_canvas_layer_texture_updater.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/caching_bitmap_canvas_layer_texture_updater.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/canvas_layer_texture_updater.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M cc/canvas_layer_texture_updater.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/content_layer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/content_layer.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M cc/content_layer_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M cc/frame_buffer_skpicture_canvas_layer_texture_updater.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/frame_buffer_skpicture_canvas_layer_texture_updater.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M cc/layer_tiling_data.h View 1 3 chunks +7 lines, -16 lines 0 comments Download
M cc/layer_tiling_data.cc View 1 3 chunks +7 lines, -12 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/quad_culler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scrollbar_layer.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M cc/skpicture_canvas_layer_texture_updater.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/skpicture_canvas_layer_texture_updater.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/texture_layer.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M cc/tiled_layer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/tiled_layer.cc View 1 8 chunks +9 lines, -34 lines 0 comments Download
M cc/tiled_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiled_layer_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/tiled_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiled_layer_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
enne (OOO)
8 years, 2 months ago (2012-10-15 20:47:18 UTC) #1
jamesr
lgtm
8 years, 2 months ago (2012-10-15 20:52:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11144023/1
8 years, 2 months ago (2012-10-15 20:58:34 UTC) #3
commit-bot: I haz the power
Failed to apply patch for cc/bitmap_canvas_layer_texture_updater.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years, 2 months ago (2012-10-15 20:59:05 UTC) #4
jamesr
Removing USE(ACCELERATED_COMPOSITING) might have killed this one, sorry!
8 years, 2 months ago (2012-10-15 21:01:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11144023/6001
8 years, 2 months ago (2012-10-15 21:14:44 UTC) #6
enne (OOO)
On 2012/10/15 21:01:05, jamesr wrote: > Removing USE(ACCELERATED_COMPOSITING) might have killed this one, sorry! No ...
8 years, 2 months ago (2012-10-15 21:16:23 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 23:16:51 UTC) #8
Change committed as 161994

Powered by Google App Engine
This is Rietveld 408576698