Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1114243005: remove (redundant) twopointradial shader (Closed)

Created:
5 years, 7 months ago by reed2
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove (redundant) twopointradial shader 1. Does anyone need the _BitmapType enum in SkShader anymore? 2. Why is there a compiler-assert in SkGpuDevice for the values? client: use 2-point conic instead. Abandoned : moved to https://codereview.chromium.org/1117423003/ BUG=skia:3800

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1123 lines) Patch
M bench/GradientBench.cpp View 4 chunks +0 lines, -19 lines 0 comments Download
M gm/blurrect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/blurroundrect.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/gradients.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M gm/gradients_no_texture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D gm/twopointradial.cpp View 1 chunk +0 lines, -112 lines 0 comments Download
M gyp/effects.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkShader.h View 3 chunks +1 line, -15 lines 0 comments Download
M include/effects/SkGradientShader.h View 1 chunk +0 lines, -33 lines 0 comments Download
M samplecode/Sample2PtRadial.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M samplecode/SampleGradients.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M samplecode/SampleShaderText.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleSlides.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 3 chunks +1 line, -7 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 3 chunks +0 lines, -26 lines 0 comments Download
D src/effects/gradients/SkTwoPointRadialGradient.h View 1 chunk +0 lines, -64 lines 0 comments Download
D src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +0 lines, -724 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 4 chunks +1 line, -65 lines 0 comments Download
M tests/GradientTest.cpp View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114243005/1
5 years, 7 months ago (2015-05-04 02:08:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114243005/20001
5 years, 7 months ago (2015-05-04 02:16:03 UTC) #4
reed2
5 years, 7 months ago (2015-05-04 02:16:34 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-04 02:19:59 UTC) #8
reed2
5 years, 7 months ago (2015-05-04 11:09:49 UTC) #10
bsalomon
On 2015/05/04 11:09:49, reed2 wrote: lgtm, the skgpudevice.cpp code is just legacy asserts that should ...
5 years, 7 months ago (2015-05-04 14:09:14 UTC) #11
hal.canary
The following PDFs render differently under pdfium: * blurrects.pdf * gradients.pdf * gradients_degenerate_2pt.pdf * gradients_local_perspective.pdf ...
5 years, 7 months ago (2015-05-04 15:13:50 UTC) #12
djsollen
5 years, 7 months ago (2015-05-04 15:16:28 UTC) #13
kTwoPointRadial_BitmapType doesn't show up in android sources so...lgtm

Powered by Google App Engine
This is Rietveld 408576698