Migrate bindings constructors to the new ExceptionState model.

Migrate bindings constructors to the new ExceptionState model.

This patch drops most 'failedToConstruct' instances outside of bindings,
migrating to the new model where ExceptionState is initialized with the
relevant data to generate a relevant exception message.

As a drive-by, it also changes WebAudio error that aren't actually
constructors to stop generating constructor-style error messages.

BUG=270033
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163540

[Mike West, 2013-12-10 11:22:39]

Hi Jochen, Sigbjørn. WDYT?

-mike

[Mike West, 2013-12-10 11:23:44]

On 2013/12/10 11:22:39, Mike West wrote:
> Hi Jochen, Sigbjørn. WDYT?
> 
> -mike

(Note, Sigbjørn, that I'm not _just_ adding you to most of these CLs because I
love to type ø. ø ø ø. ø.)

[sof, 2013-12-10 11:36:54]

Nice, I wondered if the code generator could be improved in this regard just
yesterday, and this proves it. :)

i.e., looks fine and consistent to me.

[jochen (gone - plz use gerrit), 2013-12-10 11:41:18]

https://codereview.chromium.org/111373003/diff/1/Source/bindings/scripts/code...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/111373003/diff/1/Source/bindings/scripts/code...
Source/bindings/scripts/code_generator_v8.pm:2867: 
spurious?

https://codereview.chromium.org/111373003/diff/1/Source/modules/webaudio/Dela...
File Source/modules/webaudio/DelayNode.cpp (left):

https://codereview.chromium.org/111373003/diff/1/Source/modules/webaudio/Dela...
Source/modules/webaudio/DelayNode.cpp:45: NotSupportedError,
can you clarify why this is not actually a ctor?

[Mike West, 2013-12-10 11:51:27]

https://codereview.chromium.org/111373003/diff/1/Source/bindings/scripts/code...
File Source/bindings/scripts/code_generator_v8.pm (right):

https://codereview.chromium.org/111373003/diff/1/Source/bindings/scripts/code...
Source/bindings/scripts/code_generator_v8.pm:2867: 
On 2013/12/10 11:41:19, jochen wrote:
> spurious?

Yes (though I think it's probably good practice to separate the "shift"y bits
from the local variables).

https://codereview.chromium.org/111373003/diff/1/Source/modules/webaudio/Dela...
File Source/modules/webaudio/DelayNode.cpp (left):

https://codereview.chromium.org/111373003/diff/1/Source/modules/webaudio/Dela...
Source/modules/webaudio/DelayNode.cpp:45: NotSupportedError,
On 2013/12/10 11:41:19, jochen wrote:
> can you clarify why this is not actually a ctor?

If it's called via `new DelayNode()`, it's a constructor. If it's called via
`AudioContext::createDelayNode` it's not a constructor. The calling context
should determine the message displayed, rather than hard-coding the context at
the throwing site.

See the results in 'LayoutTests/webaudio/delaynode-maxdelaylimit-expected.txt'
for an example.

[jochen (gone - plz use gerrit), 2013-12-10 11:59:58]

Good practice and perl?? Har Har

lgtm

[commit-bot: I haz the power, 2013-12-10 12:31:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/111373003/20001

[Mike West, 2013-12-10 12:49:52]

On 2013/12/10 12:31:40, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/mkwst%40chromium.org/111373003/20001

Bah. Reuploading.

[commit-bot: I haz the power, 2013-12-10 12:52:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/111373003/40001

[commit-bot: I haz the power, 2013-12-10 15:57:32]

Change committed as 163540