Source/bindings/v8/Dictionary.cpp - Issue 111373003: Migrate bindings constructors to the new ExceptionState model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/Dictionary.cpp

Issue 111373003: Migrate bindings constructors to the new ExceptionState model. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Ugh. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/Dictionary.cpp

diff --git a/Source/bindings/v8/Dictionary.cpp b/Source/bindings/v8/Dictionary.cpp

index c69efee3907bdf1f90d4d31a7742497e95a9887f..708bb709c0e63e8963f48a31150069761ef866bd 100644

--- a/Source/bindings/v8/Dictionary.cpp

+++ b/Source/bindings/v8/Dictionary.cpp

@@ -781,7 +781,7 @@ Dictionary::ConversionContext& Dictionary::ConversionContext::withAttributes(boo

void Dictionary::ConversionContext::throwTypeError(const String& detail)

{

if (forConstructor()) {

- exceptionState().throwTypeError(ExceptionMessages::failedToConstruct(interfaceName(), detail));

+ exceptionState().throwTypeError(detail);

} else {

ASSERT(!methodName().isEmpty());

exceptionState().throwTypeError(ExceptionMessages::failedToExecute(interfaceName(), methodName(), detail));