Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: Source/modules/webaudio/DelayNode.cpp

Issue 111373003: Migrate bindings constructors to the new ExceptionState model. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 24 matching lines...) Expand all
35 namespace WebCore { 35 namespace WebCore {
36 36
37 const double maximumAllowedDelayTime = 180; 37 const double maximumAllowedDelayTime = 180;
38 38
39 DelayNode::DelayNode(AudioContext* context, float sampleRate, double maxDelayTim e, ExceptionState& exceptionState) 39 DelayNode::DelayNode(AudioContext* context, float sampleRate, double maxDelayTim e, ExceptionState& exceptionState)
40 : AudioBasicProcessorNode(context, sampleRate) 40 : AudioBasicProcessorNode(context, sampleRate)
41 { 41 {
42 ScriptWrappable::init(this); 42 ScriptWrappable::init(this);
43 if (maxDelayTime <= 0 || maxDelayTime >= maximumAllowedDelayTime) { 43 if (maxDelayTime <= 0 || maxDelayTime >= maximumAllowedDelayTime) {
44 exceptionState.throwDOMException( 44 exceptionState.throwDOMException(
45 NotSupportedError, 45 NotSupportedError,
jochen (gone - plz use gerrit) 2013/12/10 11:41:19 can you clarify why this is not actually a ctor?
Mike West 2013/12/10 11:51:27 If it's called via `new DelayNode()`, it's a const
46 ExceptionMessages::failedToConstruct( 46 "max delay time (" + String::number(maxDelayTime)
47 "DelayNode", 47 + ") must be between 0 and " + String::number(maximumAllowedDelayTim e)
48 "max delay time (" + String::number(maxDelayTime) 48 + ", exclusive.");
49 + ") must be between 0 and " + String::number(maximumAllowedDela yTime)
50 + ", exclusive."));
51 return; 49 return;
52 } 50 }
53 m_processor = adoptPtr(new DelayProcessor(context, sampleRate, 1, maxDelayTi me)); 51 m_processor = adoptPtr(new DelayProcessor(context, sampleRate, 1, maxDelayTi me));
54 setNodeType(NodeTypeDelay); 52 setNodeType(NodeTypeDelay);
55 } 53 }
56 54
57 AudioParam* DelayNode::delayTime() 55 AudioParam* DelayNode::delayTime()
58 { 56 {
59 return delayProcessor()->delayTime(); 57 return delayProcessor()->delayTime();
60 } 58 }
61 59
62 } // namespace WebCore 60 } // namespace WebCore
63 61
64 #endif // ENABLE(WEB_AUDIO) 62 #endif // ENABLE(WEB_AUDIO)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698