Issue 1111793002: v8::Isolate* should be the first parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1111793002: v8::Isolate* should be the first parameter (Closed)

Created:
5 years, 7 months ago by Shiva Samsung

Modified:
5 years, 7 months ago

Reviewers:
haraken, vivekg

CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

v8::Isolate* should be the first parameter As v8::isolate is not a optional argument anymore, move isolate to first argumnet of methods in bindings BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194645

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	Source/bindings/core/v8/ScriptPromiseProperty.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/core/v8/ScriptPromisePropertyBase.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/core/v8/ScriptPromisePropertyBase.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111793002/1

5 years, 7 months ago (2015-04-29 05:08:00 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-29 06:34:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194645