Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

Issue 1111793002: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPromisePropertyBase.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
diff --git a/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp b/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
index cc94efc741cc944d0f628fc458b3680ee33c4a35..88b02d2e639f108c7afb0ad3a9599516db6fc73f 100644
--- a/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
+++ b/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
@@ -142,7 +142,7 @@ v8::Local<v8::Object> ScriptPromisePropertyBase::ensureHolderWrapper(ScriptState
return wrapper;
++i;
}
- v8::Local<v8::Object> wrapper = holder(context->Global(), m_isolate);
+ v8::Local<v8::Object> wrapper = holder(m_isolate, context->Global());
OwnPtr<ScopedPersistent<v8::Object>> weakPersistent = adoptPtr(new ScopedPersistent<v8::Object>);
weakPersistent->set(m_isolate, wrapper);
weakPersistent->setWeak(weakPersistent.get(), &clearHandle);
« no previous file with comments | « Source/bindings/core/v8/ScriptPromisePropertyBase.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698