Source/bindings/core/v8/ScriptPromisePropertyBase.h - Issue 1111793002: v8::Isolate* should be the first parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptPromisePropertyBase.h

Issue 1111793002: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptPromisePropertyBase.h

diff --git a/Source/bindings/core/v8/ScriptPromisePropertyBase.h b/Source/bindings/core/v8/ScriptPromisePropertyBase.h

index ecef0b305a96cd4d2c2f077a82af54b585801119..eec77f41b91837c95e2f088da507c0e50d227b61 100644

--- a/Source/bindings/core/v8/ScriptPromisePropertyBase.h

+++ b/Source/bindings/core/v8/ScriptPromisePropertyBase.h

@@ -54,7 +54,7 @@ protected:

// the property's execution context and the world it is

// creating/settling promises in; the implementation should use

// this context.

- virtual v8::Handle<v8::Object> holder(v8::Handle<v8::Object> creationContext, v8::Isolate*) = 0;

+ virtual v8::Handle<v8::Object> holder(v8::Isolate*, v8::Handle<v8::Object> creationContext) = 0;

virtual v8::Handle<v8::Value> resolvedValue(v8::Isolate*, v8::Handle<v8::Object> creationContext) = 0;

virtual v8::Handle<v8::Value> rejectedValue(v8::Isolate*, v8::Handle<v8::Object> creationContext) = 0;