Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: Source/bindings/core/v8/ScriptPromiseProperty.h

Issue 1111793002: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptPromisePropertyBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptPromiseProperty.h
diff --git a/Source/bindings/core/v8/ScriptPromiseProperty.h b/Source/bindings/core/v8/ScriptPromiseProperty.h
index cec372b6141abcd2e42d45858d1615c4f32f5aec..fabef7c368c0dedbe723b94349b66eb40dc70ed7 100644
--- a/Source/bindings/core/v8/ScriptPromiseProperty.h
+++ b/Source/bindings/core/v8/ScriptPromiseProperty.h
@@ -71,7 +71,7 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- virtual v8::Handle<v8::Object> holder(v8::Handle<v8::Object> creationContext, v8::Isolate*) override;
+ virtual v8::Handle<v8::Object> holder(v8::Isolate*, v8::Handle<v8::Object> creationContext) override;
virtual v8::Handle<v8::Value> resolvedValue(v8::Isolate*, v8::Handle<v8::Object> creationContext) override;
virtual v8::Handle<v8::Value> rejectedValue(v8::Isolate*, v8::Handle<v8::Object> creationContext) override;
@@ -117,7 +117,7 @@ void ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::reject(PassR
}
template<typename HolderType, typename ResolvedType, typename RejectedType>
-v8::Handle<v8::Object> ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::holder(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+v8::Handle<v8::Object> ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::holder(v8::Isolate* isolate, v8::Handle<v8::Object> creationContext)
{
v8::Handle<v8::Value> value = toV8(m_holder, creationContext, isolate);
return value.As<v8::Object>();
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptPromisePropertyBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698