Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1111163003: Replace v8::Handle<> with v8::Local<> in bindings/core/v8/* (Closed)

Created:
5 years, 7 months ago by deepak.s
Modified:
5 years, 7 months ago
Reviewers:
haraken, vivekg
CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace v8::Handle<> with v8::Local<> in bindings/core/v8/* Complete the Handle<> to Local<> transition in core/v8/* BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -337 lines) Patch
M Source/bindings/core/v8/RejectedPromises.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/ScopedPersistent.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptCallStackFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptCallStackFactory.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/ScriptFunction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptProfiler.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromise.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromise.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseProperty.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyBase.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyBase.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromiseTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptState.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/ScriptState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptWrappable.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptWrappable.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValueFactory.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValueTest.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/SharedPersistent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ToV8.h View 6 chunks +35 lines, -35 lines 0 comments Download
M Source/bindings/core/v8/ToV8.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 29 chunks +61 lines, -61 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 23 chunks +39 lines, -39 lines 0 comments Download
M Source/bindings/core/v8/V8BindingForTesting.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8BindingForTesting.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8Initializer.cpp View 10 chunks +16 lines, -16 lines 0 comments Download
M Source/bindings/core/v8/V8PerContextData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8PerContextData.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8PerIsolateData.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/V8PerIsolateData.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/core/v8/V8StringResource.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8StringResource.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M Source/bindings/core/v8/V8ThrowException.h View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/bindings/core/v8/V8ThrowException.cpp View 3 chunks +20 lines, -20 lines 0 comments Download
M Source/bindings/core/v8/WrapCanvasContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/WrapperTypeInfo.h View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/WrapperTypeInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
deepak.s
PTAL? Thanks!
5 years, 7 months ago (2015-04-29 09:02:29 UTC) #2
vivekg
lgtm
5 years, 7 months ago (2015-04-29 09:03:23 UTC) #4
haraken
LGTM
5 years, 7 months ago (2015-04-29 11:34:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111163003/1
5 years, 7 months ago (2015-04-29 11:34:45 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 11:38:19 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194649

Powered by Google App Engine
This is Rietveld 408576698