Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: Source/bindings/core/v8/RejectedPromises.cpp

Issue 1111163003: Replace v8::Handle<> with v8::Local<> in bindings/core/v8/* (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScopedPersistent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/RejectedPromises.cpp
diff --git a/Source/bindings/core/v8/RejectedPromises.cpp b/Source/bindings/core/v8/RejectedPromises.cpp
index 5b4129324c6e4b15a476d7c8d69232c5841735f6..312f2651cd544c8de46c3dc09436773d31c1d8b8 100644
--- a/Source/bindings/core/v8/RejectedPromises.cpp
+++ b/Source/bindings/core/v8/RejectedPromises.cpp
@@ -19,7 +19,7 @@ static const unsigned maxReportedHandlersPendingResolution = 1000;
class RejectedPromises::Message final : public NoBaseWillBeGarbageCollectedFinalized<RejectedPromises::Message> {
public:
- static PassOwnPtrWillBeRawPtr<Message> create(ScriptState* scriptState, v8::Handle<v8::Promise> promise, const ScriptValue& exception, const String& errorMessage, const String& resourceName, int scriptId, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack)
+ static PassOwnPtrWillBeRawPtr<Message> create(ScriptState* scriptState, v8::Local<v8::Promise> promise, const ScriptValue& exception, const String& errorMessage, const String& resourceName, int scriptId, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack)
{
return adoptPtrWillBeNoop(new Message(scriptState, promise, exception, errorMessage, resourceName, scriptId, lineNumber, columnNumber, callStack));
}
@@ -34,7 +34,7 @@ public:
return m_collected || !m_scriptState->contextIsValid();
}
- bool hasPromise(v8::Handle<v8::Value> promise)
+ bool hasPromise(v8::Local<v8::Value> promise)
{
ScriptState::Scope scope(m_scriptState);
return promise == m_promise.newLocal(m_scriptState->isolate());
@@ -52,11 +52,11 @@ public:
return;
ScriptState::Scope scope(m_scriptState);
- v8::Handle<v8::Value> value = m_promise.newLocal(m_scriptState->isolate());
+ v8::Local<v8::Value> value = m_promise.newLocal(m_scriptState->isolate());
// Either collected or https://crbug.com/450330
if (value.IsEmpty() || !value->IsPromise())
return;
- ASSERT(!v8::Handle<v8::Promise>::Cast(value)->HasHandler());
+ ASSERT(!v8::Local<v8::Promise>::Cast(value)->HasHandler());
const String errorMessage = "Uncaught (in promise)";
Vector<ScriptValue> args;
@@ -93,7 +93,7 @@ public:
}
private:
- Message(ScriptState* scriptState, v8::Handle<v8::Promise> promise, const ScriptValue& exception, const String& errorMessage, const String& resourceName, int scriptId, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack)
+ Message(ScriptState* scriptState, v8::Local<v8::Promise> promise, const ScriptValue& exception, const String& errorMessage, const String& resourceName, int scriptId, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack)
: m_scriptState(scriptState)
, m_promise(scriptState->isolate(), promise)
, m_exception(exception)
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScopedPersistent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698