Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: Source/bindings/core/v8/SerializedScriptValueTest.cpp

Issue 1111163003: Replace v8::Handle<> with v8::Local<> in bindings/core/v8/* (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/SerializedScriptValueTest.cpp
diff --git a/Source/bindings/core/v8/SerializedScriptValueTest.cpp b/Source/bindings/core/v8/SerializedScriptValueTest.cpp
index 825e97ed3ba879edf9092b92faae1cbe78c9b595..b29ba9a5784dc487c98d24a83e268a883d55181e 100644
--- a/Source/bindings/core/v8/SerializedScriptValueTest.cpp
+++ b/Source/bindings/core/v8/SerializedScriptValueTest.cpp
@@ -25,7 +25,7 @@ public:
}
v8::Isolate* isolate() const { return m_scope.isolate(); }
- v8::Handle<v8::Object> creationContext() const { return m_scope.scriptState()->context()->Global(); }
+ v8::Local<v8::Object> creationContext() const { return m_scope.scriptState()->context()->Global(); }
protected:
V8TestingScope m_scope;
@@ -40,13 +40,13 @@ TEST_F(SerializedScriptValueTest, UserSelectedFile)
ASSERT_EQ(File::IsUserVisible, originalFile->userVisibility());
ASSERT_EQ(filePath, originalFile->path());
- v8::Handle<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());
+ v8::Local<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());
RefPtr<SerializedScriptValue> serializedScriptValue =
SerializedScriptValueFactory::instance().create(v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION, isolate());
- v8::Handle<v8::Value> v8File = serializedScriptValue->deserialize(isolate());
+ v8::Local<v8::Value> v8File = serializedScriptValue->deserialize(isolate());
ASSERT_TRUE(V8File::hasInstance(v8File, isolate()));
- File* file = V8File::toImpl(v8::Handle<v8::Object>::Cast(v8File));
+ File* file = V8File::toImpl(v8::Local<v8::Object>::Cast(v8File));
EXPECT_TRUE(file->hasBackingFile());
EXPECT_EQ(File::IsUserVisible, file->userVisibility());
EXPECT_EQ(filePath, file->path());
@@ -60,13 +60,13 @@ TEST_F(SerializedScriptValueTest, FileConstructorFile)
ASSERT_EQ(File::IsNotUserVisible, originalFile->userVisibility());
ASSERT_EQ("hello.txt", originalFile->name());
- v8::Handle<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());
+ v8::Local<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());
RefPtr<SerializedScriptValue> serializedScriptValue =
SerializedScriptValueFactory::instance().create(v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION, isolate());
- v8::Handle<v8::Value> v8File = serializedScriptValue->deserialize(isolate());
+ v8::Local<v8::Value> v8File = serializedScriptValue->deserialize(isolate());
ASSERT_TRUE(V8File::hasInstance(v8File, isolate()));
- File* file = V8File::toImpl(v8::Handle<v8::Object>::Cast(v8File));
+ File* file = V8File::toImpl(v8::Local<v8::Object>::Cast(v8File));
EXPECT_FALSE(file->hasBackingFile());
EXPECT_EQ(File::IsNotUserVisible, file->userVisibility());
EXPECT_EQ("hello.txt", file->name());
« no previous file with comments | « Source/bindings/core/v8/SerializedScriptValueFactory.cpp ('k') | Source/bindings/core/v8/SharedPersistent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698