Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 11106012: Consistently make the bounds check for AccessArgumentsAt explicit. (Closed)

Created:
5 years, 1 month ago by Sven Panne
Modified:
5 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Consistently make the bounds check for AccessArgumentsAt explicit. This has the advantage that AccessArgumentsAt itself can't deopt anymore and the bounds check is visible for the elimination phase. Furthermore, things are simply more consistent now, a good thing in itself. :-) Committed: https://code.google.com/p/v8/source/detail?r=12721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -40 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
Trybot results:

Messages

Total messages: 2 (0 generated)
Michael Starzinger
LGTM. As discussed offline, the benefits most certainly outweigh the additional instructions for the GenerateArguments ...
5 years, 1 month ago (2012-10-12 12:59:25 UTC) #1
Sven Panne
5 years, 1 month ago (2012-10-15 07:25:01 UTC) #2
As discussed offline, the "hot stuff" should be crankshafted, anyway, and this
should use less instructions. In addition, the Lithium instruction can't deopt
anymore, so this should be nicer to the register allocator.

What we would really need here is an optimization across Lithium operation
boundaries, so the cmp/branch/sub would be simplified to a sub/branch. Peephole
optimizations, anyone...?

Landing...

Powered by Google App Engine
This is Rietveld efc10ee0f