Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 11106012: Consistently make the bounds check for AccessArgumentsAt explicit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2261 matching lines...) Expand 10 before | Expand all | Expand 10 after
2272 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) { 2272 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) {
2273 // There are no real uses of the arguments object. 2273 // There are no real uses of the arguments object.
2274 // arguments.length and element access are supported directly on 2274 // arguments.length and element access are supported directly on
2275 // stack arguments, and any real arguments object use causes a bailout. 2275 // stack arguments, and any real arguments object use causes a bailout.
2276 // So this value is never used. 2276 // So this value is never used.
2277 return NULL; 2277 return NULL;
2278 } 2278 }
2279 2279
2280 2280
2281 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2281 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2282 LOperand* arguments = UseRegister(instr->arguments()); 2282 LOperand* args = UseRegister(instr->arguments());
2283 LOperand* length = UseTempRegister(instr->length()); 2283 LOperand* length = UseTempRegister(instr->length());
2284 LOperand* index = Use(instr->index()); 2284 LOperand* index = Use(instr->index());
2285 LAccessArgumentsAt* result = 2285 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index));
2286 new(zone()) LAccessArgumentsAt(arguments, length, index);
2287 return AssignEnvironment(DefineAsRegister(result));
2288 } 2286 }
2289 2287
2290 2288
2291 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) { 2289 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) {
2292 LOperand* object = UseFixed(instr->value(), eax); 2290 LOperand* object = UseFixed(instr->value(), eax);
2293 LToFastProperties* result = new(zone()) LToFastProperties(object); 2291 LToFastProperties* result = new(zone()) LToFastProperties(object);
2294 return MarkAsCall(DefineFixed(result, eax), instr); 2292 return MarkAsCall(DefineFixed(result, eax), instr);
2295 } 2293 }
2296 2294
2297 2295
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
2433 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2431 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2434 LOperand* object = UseRegister(instr->object()); 2432 LOperand* object = UseRegister(instr->object());
2435 LOperand* index = UseTempRegister(instr->index()); 2433 LOperand* index = UseTempRegister(instr->index());
2436 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2434 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2437 } 2435 }
2438 2436
2439 2437
2440 } } // namespace v8::internal 2438 } } // namespace v8::internal
2441 2439
2442 #endif // V8_TARGET_ARCH_IA32 2440 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698