Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2107)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 11106012: Consistently make the bounds check for AccessArgumentsAt explicit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2146 matching lines...) Expand 10 before | Expand all | Expand 10 after
2157 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) { 2157 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) {
2158 // There are no real uses of the arguments object. 2158 // There are no real uses of the arguments object.
2159 // arguments.length and element access are supported directly on 2159 // arguments.length and element access are supported directly on
2160 // stack arguments, and any real arguments object use causes a bailout. 2160 // stack arguments, and any real arguments object use causes a bailout.
2161 // So this value is never used. 2161 // So this value is never used.
2162 return NULL; 2162 return NULL;
2163 } 2163 }
2164 2164
2165 2165
2166 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2166 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2167 LOperand* arguments = UseRegister(instr->arguments()); 2167 LOperand* args = UseRegister(instr->arguments());
2168 LOperand* length = UseTempRegister(instr->length()); 2168 LOperand* length = UseTempRegister(instr->length());
2169 LOperand* index = UseRegister(instr->index()); 2169 LOperand* index = UseRegister(instr->index());
2170 LAccessArgumentsAt* result = 2170 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index));
2171 new(zone()) LAccessArgumentsAt(arguments, length, index);
2172 return AssignEnvironment(DefineAsRegister(result));
2173 } 2171 }
2174 2172
2175 2173
2176 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) { 2174 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) {
2177 LOperand* object = UseFixed(instr->value(), r0); 2175 LOperand* object = UseFixed(instr->value(), r0);
2178 LToFastProperties* result = new(zone()) LToFastProperties(object); 2176 LToFastProperties* result = new(zone()) LToFastProperties(object);
2179 return MarkAsCall(DefineFixed(result, r0), instr); 2177 return MarkAsCall(DefineFixed(result, r0), instr);
2180 } 2178 }
2181 2179
2182 2180
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
2310 2308
2311 2309
2312 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2310 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2313 LOperand* object = UseRegister(instr->object()); 2311 LOperand* object = UseRegister(instr->object());
2314 LOperand* index = UseRegister(instr->index()); 2312 LOperand* index = UseRegister(instr->index());
2315 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2313 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2316 } 2314 }
2317 2315
2318 2316
2319 } } // namespace v8::internal 2317 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698