Remove legacy NVPR support

Remove legacy NVPR support

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/505306374de4ceca7b6dfcf155fb64840c7f07a0

[jvanverth1, 2015-04-27 16:21:44]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, cdalton@nvidia.com

[bsalomon, 2015-04-27 17:10:20]

lgtm with some inline comments.

https://codereview.chromium.org/1110553003/diff/1/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/1110553003/diff/1/src/gpu/gl/GrGLCaps.cpp#new...
src/gpu/gl/GrGLCaps.cpp:351: // We need one texturing method: using the newer
NVPR API additions that support
Maybe change this comment to say we only support v1.3+ of GL_NV_path_rendering
which has glProgramPathFragmentInputGenNV.

https://codereview.chromium.org/1110553003/diff/1/src/gpu/gl/GrGLPathRenderin...
File src/gpu/gl/GrGLPathRendering.cpp (right):

https://codereview.chromium.org/1110553003/diff/1/src/gpu/gl/GrGLPathRenderin...
src/gpu/gl/GrGLPathRendering.cpp:88: GrGLenum matrixMode = GR_GL_PATH_MODELVIEW;
I think this and the next line can be killed since we aren't using fixed
function matrices for NVPR anymore.

[jvanverth1, 2015-04-27 17:20:59]

https://codereview.chromium.org/1110553003/diff/1/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/1110553003/diff/1/src/gpu/gl/GrGLCaps.cpp#new...
src/gpu/gl/GrGLCaps.cpp:351: // We need one texturing method: using the newer
NVPR API additions that support
On 2015/04/27 17:10:20, bsalomon wrote:
> Maybe change this comment to say we only support v1.3+ of GL_NV_path_rendering
> which has glProgramPathFragmentInputGenNV.

Acknowledged.

https://codereview.chromium.org/1110553003/diff/1/src/gpu/gl/GrGLPathRenderin...
File src/gpu/gl/GrGLPathRendering.cpp (right):

https://codereview.chromium.org/1110553003/diff/1/src/gpu/gl/GrGLPathRenderin...
src/gpu/gl/GrGLPathRendering.cpp:88: GrGLenum matrixMode = GR_GL_PATH_MODELVIEW;
On 2015/04/27 17:10:20, bsalomon wrote:
> I think this and the next line can be killed since we aren't using fixed
> function matrices for NVPR anymore.

Don't we still want to ensure this matrix is identity rather than garbage?

[jvanverth1, 2015-04-27 17:32:30]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2015-04-27 17:32:30]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1110553003/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-04-27 17:32:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110553003/20001

[Chris Dalton, 2015-04-27 17:33:19]

This looks good, I'm excited to see the old code get cleaned out.

The latest public drivers all fully support v1.3, so this should be good to go.

https://codereview.chromium.org/1110553003/diff/1/src/gpu/gl/GrGLPathRenderin...
File src/gpu/gl/GrGLPathRendering.cpp (right):

https://codereview.chromium.org/1110553003/diff/1/src/gpu/gl/GrGLPathRenderin...
src/gpu/gl/GrGLPathRendering.cpp:88: GrGLenum matrixMode = GR_GL_PATH_MODELVIEW;
On 2015/04/27 17:20:59, jvanverth1 wrote:
> On 2015/04/27 17:10:20, bsalomon wrote:
> > I think this and the next line can be killed since we aren't using fixed
> > function matrices for NVPR anymore.
> 
> Don't we still want to ensure this matrix is identity rather than garbage?

Yeah, for "non-legacy" nvpr we still use the fixed function matrices, they're
just aliased as GL_PATH_MODELVIEW_NV/GL_PATH_PROJECTION_NV (you can see that
GL_PATH_MODELVIEW_NV == GL_MODELVIEW). The way it works is nvpr ignores your
vertex shader, and you instead program your transform with GL_PATH_MODELVIEW_NV
and your varyings with glProgramPathFragmentInputGenNV.

We put the path transform into the projection matrix, so I think it's still
important to reset the modelview to the identity here.

[commit-bot: I haz the power, 2015-04-27 17:36:32]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/505306374de4ceca7b6dfcf155fb64840c7f07a0