Hook up Android closed captions 'enabled' setting to Blink

Hook up Android closed captions 'enabled' setting to Blink

Add an API for the Android closed captions state change to be
plumbed down to Blink.

Blink-side CL: https://codereview.chromium.org/1118613002/

BUG=457850, 388588
Committed: https://crrev.com/8ee695f141f1468641ab4da1a9dd82db26ec58e4
Cr-Commit-Position: refs/heads/master@{#338350}

[srivats, 2015-04-29 23:31:41]

Hi all,

This is the Chromium-side implementation for hooking up the Android platform
closed captions state with the MediaElement in Blink.

Here's the Blink-side CL: https://codereview.chromium.org/1118613002

dtrainor: content/public/android/
nasko: content/browser, content/renderer, content/common

PTAL

Thanks,
Sunitha

[David Trainor- moved to gerrit, 2015-04-30 00:08:39]

content/public/android lgtm.

[nasko, 2015-04-30 22:50:51]

On 2015/04/30 00:08:39, David Trainor wrote:
> content/public/android lgtm.

Who is reviewing content/browser/android? The CL looks good, but I'd defer the
android bits to experts in the area.

[srivats, 2015-05-01 23:07:04]

On 2015/04/30 22:50:51, nasko wrote:
> On 2015/04/30 00:08:39, David Trainor wrote:
> > content/public/android lgtm.
> 
> Who is reviewing content/browser/android? The CL looks good, but I'd defer the
> android bits to experts in the area.

dtrainer: Can you review the content/browser/android bits as well?

[David Trainor- moved to gerrit, 2015-05-01 23:31:36]

On 2015/05/01 23:07:04, srivats wrote:
> On 2015/04/30 22:50:51, nasko wrote:
> > On 2015/04/30 00:08:39, David Trainor wrote:
> > > content/public/android lgtm.
> > 
> > Who is reviewing content/browser/android? The CL looks good, but I'd defer
the
> > android bits to experts in the area.
> 
> dtrainer: Can you review the content/browser/android bits as well?

content/browser/android lgtm too.  Thanks!

[nasko, 2015-05-01 23:34:43]

On 2015/05/01 23:31:36, David Trainor wrote:
> On 2015/05/01 23:07:04, srivats wrote:
> > On 2015/04/30 22:50:51, nasko wrote:
> > > On 2015/04/30 00:08:39, David Trainor wrote:
> > > > content/public/android lgtm.
> > > 
> > > Who is reviewing content/browser/android? The CL looks good, but I'd defer
> the
> > > android bits to experts in the area.
> > 
> > dtrainer: Can you review the content/browser/android bits as well?
> 
> content/browser/android lgtm too.  Thanks!

The rest of content/ LGTM

[srivats, 2015-07-09 21:35:16]

Updated this CL based on some changes made in the Blink-side implementation for
this change.
The boolean textTracksEnabled is not passed on anymore. It instead sets
TextTrackKindUserPreference enum to Captions when the boolean is true and sets
it to Default when false.

[David Trainor- moved to gerrit, 2015-07-09 21:46:47]

nits but still lgtm.

https://codereview.chromium.org/1110103004/diff/20001/content/browser/android...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/1110103004/diff/20001/content/browser/android...
content/browser/android/content_view_core_impl.cc:1308: if (web_contents_)
I don't think this can ever be null.

https://codereview.chromium.org/1110103004/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1110103004/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:1579: if (params.text_tracks_enabled)
I'm not sure, but does the styleguide require {} if the line wraps?  It looks
like some other cases in this file do {} when multiple lines even when it's a
single command.

[nasko, 2015-07-10 09:09:07]

Still LGTM

[srivats, 2015-07-10 19:37:00]

The CQ bit was checked by srivats@amazon.com

[srivats, 2015-07-10 19:37:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/1110103004/#ps40001
(title: "Addressed lgtm nits")

[commit-bot: I haz the power, 2015-07-10 19:38:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110103004/40001

[commit-bot: I haz the power, 2015-07-10 20:43:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-10 20:44:47]

Patchset 3 (id:??) landed as
https://crrev.com/8ee695f141f1468641ab4da1a9dd82db26ec58e4
Cr-Commit-Position: refs/heads/master@{#338350}

[srivats, 2016-02-01 22:23:14]

Patchset #4 (id:60001) has been deleted