content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningChangeDelegate.java - Issue 1110103004: Hook up Android closed captions 'enabled' setting to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningChangeDelegate.java

Issue 1110103004: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed lgtm nits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/TextTrackSettings.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningChangeDelegate.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningChangeDelegate.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningChangeDelegate.java

index d9b08a770897d6eb54df144e18ba865aac5e19e9..94d3e3eb078a5bd903d2638c91a23733a3383fa0 100644

--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningChangeDelegate.java

+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningChangeDelegate.java

@@ -32,7 +32,7 @@ public class CaptioningChangeDelegate {

@VisibleForTesting

public static final String DEFAULT_CAPTIONING_PREF_VALUE = "";

- private boolean mTextTrackEnabled;

+ private boolean mTextTracksEnabled;

private String mTextTrackBackgroundColor;

private String mTextTrackFontFamily;

@@ -50,7 +50,7 @@ public class CaptioningChangeDelegate {

* @see android.view.accessibility.CaptioningManager.CaptioningChangeListener#onEnabledChanged

public void onEnabledChanged(boolean enabled) {

- mTextTrackEnabled = enabled;

+ mTextTracksEnabled = enabled;

notifySettingsChanged();

}

@@ -294,8 +294,8 @@ public class CaptioningChangeDelegate {

* @param listener the listener to notify.

public void notifyListener(SystemCaptioningBridgeListener listener) {

- if (mTextTrackEnabled) {

- final TextTrackSettings settings = new TextTrackSettings(

+ if (mTextTracksEnabled) {

+ final TextTrackSettings settings = new TextTrackSettings(mTextTracksEnabled,

mTextTrackBackgroundColor, mTextTrackFontFamily, mTextTrackFontStyle,

mTextTrackFontVariant, mTextTrackTextColor, mTextTrackTextShadow,

mTextTrackTextSize);