content/common/frame_messages.h - Issue 1110103004: Hook up Android closed captions 'enabled' setting to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 1110103004: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed lgtm nits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 5acb07d3bf93d1f6059b72d971585596a861ff0f..5d7fef25e0451b62f2d97e007863054bcf5492ed 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -359,6 +359,9 @@ IPC_STRUCT_BEGIN(FrameHostMsg_OpenURL_Params)

IPC_STRUCT_END()

IPC_STRUCT_BEGIN(FrameMsg_TextTrackSettings_Params)

+ // Text tracks on/off state

+ IPC_STRUCT_MEMBER(bool, text_tracks_enabled)

// Background color of the text track.

IPC_STRUCT_MEMBER(std::string, text_track_background_color)

@@ -599,7 +602,7 @@ IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateName, std::string /* name */)

// new origin.

IPC_MESSAGE_ROUTED1(FrameMsg_DidUpdateOrigin, url::Origin /* origin */)

-// Send to the RenderFrame to set text track style settings.

+// Send to the RenderFrame to set text tracks state and style settings.

// Sent for top-level frames.

IPC_MESSAGE_ROUTED1(FrameMsg_SetTextTrackSettings,

FrameMsg_TextTrackSettings_Params /* params */)