Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 1110103004: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed lgtm nits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/android/content_view_core_impl.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 9e70f65118c4b6f12ede2807ccd3ca9ebf4fe158..6495133e3b80a095c50ca74f687e8259f2ec28c0 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -1281,6 +1281,7 @@ void ContentViewCoreImpl::SetAccessibilityEnabled(JNIEnv* env, jobject obj,
void ContentViewCoreImpl::SetTextTrackSettings(JNIEnv* env,
jobject obj,
+ jboolean textTracksEnabled,
jstring textTrackBackgroundColor,
jstring textTrackFontFamily,
jstring textTrackFontStyle,
@@ -1289,6 +1290,7 @@ void ContentViewCoreImpl::SetTextTrackSettings(JNIEnv* env,
jstring textTrackTextShadow,
jstring textTrackTextSize) {
FrameMsg_TextTrackSettings_Params params;
+ params.text_tracks_enabled = textTracksEnabled;
params.text_track_background_color = ConvertJavaStringToUTF8(
env, textTrackBackgroundColor);
params.text_track_font_family = ConvertJavaStringToUTF8(
@@ -1303,7 +1305,6 @@ void ContentViewCoreImpl::SetTextTrackSettings(JNIEnv* env,
env, textTrackTextShadow);
params.text_track_text_size = ConvertJavaStringToUTF8(
env, textTrackTextSize);
-
web_contents_->GetMainFrame()->SetTextTrackSettings(params);
}
« no previous file with comments | « content/browser/android/content_view_core_impl.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698