Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1109043003: Apply automated fixits for Chrome clang plugin to chrome. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
Reviewers:
Nico
CC:
aboxhall+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, gcasto+watchlist_chromium.org, grt+watch_chromium.org, je_julie(Not used), Matt Giuca, mkwst+watchlist-passwords_chromium.org, nektar+watch_chromium.org, plundblad+watch_chromium.org, tapted, tfarina, vabr+watchlist_chromium.org, wfh+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply automated fixits for Chrome clang plugin to chrome. Working on trimming down plugin warnings on the Windows clang build. BUG=467287 NOPRESUBMIT=true Committed: https://crrev.com/bcb225732617dc751c631f20adc6c9507e56cb8c Cr-Commit-Position: refs/heads/master@{#327576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -168 lines) Patch
M chrome/browser/chrome_select_file_dialog_factory_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_writer.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_win.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/hang_monitor/hung_plugin_action.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/hang_monitor/hung_window_detector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/jumplist_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/pdf_to_emf_converter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_state_changer_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/conflicts_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/web_applications/update_shortcut_worker_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/multi_process_lock_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi_last_run_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer/mini_string_test.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/installer/util/conditional_work_item_list.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/installer/util/create_dir_work_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/create_dir_work_item_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/installer/util/create_reg_key_work_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/create_reg_key_work_item_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_after_reboot_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_reg_key_work_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/delete_reg_value_work_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/delete_reg_value_work_item_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/installer/util/duplicate_tree_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_binaries_distribution.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/installer/util/html_dialog.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/html_dialog_impl.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/installer/util/installation_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/lzma_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/move_tree_work_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/move_tree_work_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/product_state_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/product_unittest.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/util/registry_key_backup_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/self_reg_work_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/set_reg_value_work_item.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/set_reg_value_work_item_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/work_item_list.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/util/work_item_list_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
dcheng
5 years, 7 months ago (2015-04-29 18:53:03 UTC) #2
Nico
lgtm
5 years, 7 months ago (2015-04-29 18:59:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109043003/1
5 years, 7 months ago (2015-04-29 19:00:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/59980)
5 years, 7 months ago (2015-04-29 19:12:31 UTC) #7
Nico
I guess the problem is: ** Presubmit Warnings ** New code should not use wstrings. ...
5 years, 7 months ago (2015-04-29 19:13:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109043003/1
5 years, 7 months ago (2015-04-29 19:14:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:45:10 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:46:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcb225732617dc751c631f20adc6c9507e56cb8c
Cr-Commit-Position: refs/heads/master@{#327576}

Powered by Google App Engine
This is Rietveld 408576698