Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4444)

Unified Diff: chrome/installer/util/conditional_work_item_list.h

Issue 1109043003: Apply automated fixits for Chrome clang plugin to chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/install_worker_unittest.cc ('k') | chrome/installer/util/copy_tree_work_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/conditional_work_item_list.h
diff --git a/chrome/installer/util/conditional_work_item_list.h b/chrome/installer/util/conditional_work_item_list.h
index 97cdd7ae95d18a6006a702fe50189d90d53f11da..ae5cdc9c7645da8c83019bd864a4ba4c01b0e47d 100644
--- a/chrome/installer/util/conditional_work_item_list.h
+++ b/chrome/installer/util/conditional_work_item_list.h
@@ -15,15 +15,15 @@
class ConditionalWorkItemList : public WorkItemList {
public:
explicit ConditionalWorkItemList(Condition* condition);
- virtual ~ConditionalWorkItemList();
+ ~ConditionalWorkItemList() override;
// If condition_->ShouldRun() returns true, then execute the items in this
// list and return true iff they all succeed. If condition_->ShouldRun()
// returns false, does nothing and returns true.
- virtual bool Do();
+ bool Do() override;
// Does a rollback of the items (if any) that were run in Do.
- virtual void Rollback();
+ void Rollback() override;
protected:
// Pointer to a Condition that is used to determine whether to run this
@@ -38,7 +38,7 @@ class ConditionRunIfFileExists : public WorkItem::Condition {
public:
explicit ConditionRunIfFileExists(const base::FilePath& key_path)
: key_path_(key_path) {}
- bool ShouldRun() const;
+ bool ShouldRun() const override;
private:
base::FilePath key_path_;
@@ -49,9 +49,9 @@ class ConditionRunIfFileExists : public WorkItem::Condition {
class Not : public WorkItem::Condition {
public:
explicit Not(WorkItem::Condition* original_condition);
- ~Not();
+ ~Not() override;
- bool ShouldRun() const;
+ bool ShouldRun() const override;
private:
scoped_ptr<WorkItem::Condition> original_condition_;
« no previous file with comments | « chrome/installer/setup/install_worker_unittest.cc ('k') | chrome/installer/util/copy_tree_work_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698