chrome/browser/printing/pdf_to_emf_converter.cc - Issue 1109043003: Apply automated fixits for Chrome clang plugin to chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/pdf_to_emf_converter.cc

Issue 1109043003: Apply automated fixits for Chrome clang plugin to chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_win_unittest.cc ('k') | chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/pdf_to_emf_converter.cc

diff --git a/chrome/browser/printing/pdf_to_emf_converter.cc b/chrome/browser/printing/pdf_to_emf_converter.cc

index 0e22ccab2c033d42a6d68070cd5c1c6211d03b6f..f7bfceb4663a44ccf2bad05e46d97b265d1f6a1d 100644

--- a/chrome/browser/printing/pdf_to_emf_converter.cc

+++ b/chrome/browser/printing/pdf_to_emf_converter.cc

@@ -61,7 +61,7 @@ class LazyEmf : public MetafilePlayer {

public:

LazyEmf(const scoped_refptr<RefCountedTempDir>& temp_dir, ScopedTempFile file)

: temp_dir_(temp_dir), file_(file.Pass()) {}

- virtual ~LazyEmf() { Close(); }

+ ~LazyEmf() override { Close(); }

bool SafePlayback(HDC hdc) const override;

bool SaveTo(base::File* file) const override;

@@ -142,7 +142,7 @@ class PdfToEmfUtilityProcessHostClient

ScopedTempFile emf_;

};

- virtual ~PdfToEmfUtilityProcessHostClient();

+ ~PdfToEmfUtilityProcessHostClient() override;

bool Send(IPC::Message* msg);

@@ -181,7 +181,7 @@ class PdfToEmfConverterImpl : public PdfToEmfConverter {

public:

PdfToEmfConverterImpl();

- virtual ~PdfToEmfConverterImpl();

+ ~PdfToEmfConverterImpl() override;

void Start(const scoped_refptr<base::RefCountedMemory>& data,

const PdfRenderSettings& conversion_settings,