Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/browser/component_updater/sw_reporter_installer_win.cc

Issue 1109043003: Apply automated fixits for Chrome clang plugin to chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/sw_reporter_installer_win.cc
diff --git a/chrome/browser/component_updater/sw_reporter_installer_win.cc b/chrome/browser/component_updater/sw_reporter_installer_win.cc
index 3ba552745fda42ae9ca0bbaf6c55725fb28e98c0..4dddf2e0e562b77a6cd6d0be62f90f41b24905ac 100644
--- a/chrome/browser/component_updater/sw_reporter_installer_win.cc
+++ b/chrome/browser/component_updater/sw_reporter_installer_win.cc
@@ -290,23 +290,23 @@ class SwReporterInstallerTraits : public ComponentInstallerTraits {
public:
explicit SwReporterInstallerTraits(PrefService* prefs) : prefs_(prefs) {}
- virtual ~SwReporterInstallerTraits() {}
+ ~SwReporterInstallerTraits() override {}
- virtual bool VerifyInstallation(const base::DictionaryValue& manifest,
- const base::FilePath& dir) const {
+ bool VerifyInstallation(const base::DictionaryValue& manifest,
+ const base::FilePath& dir) const override {
return base::PathExists(dir.Append(kSwReporterExeName));
}
- virtual bool CanAutoUpdate() const { return true; }
+ bool CanAutoUpdate() const override { return true; }
- virtual bool OnCustomInstall(const base::DictionaryValue& manifest,
- const base::FilePath& install_dir) {
+ bool OnCustomInstall(const base::DictionaryValue& manifest,
+ const base::FilePath& install_dir) override {
return true;
}
- virtual void ComponentReady(const base::Version& version,
- const base::FilePath& install_dir,
- scoped_ptr<base::DictionaryValue> manifest) {
+ void ComponentReady(const base::Version& version,
+ const base::FilePath& install_dir,
+ scoped_ptr<base::DictionaryValue> manifest) override {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
ReportVersionWithUma(version);
@@ -352,11 +352,11 @@ class SwReporterInstallerTraits : public ComponentInstallerTraits {
}
}
- virtual base::FilePath GetBaseDirectory() const { return install_dir(); }
+ base::FilePath GetBaseDirectory() const override { return install_dir(); }
- virtual void GetHash(std::vector<uint8_t>* hash) const { GetPkHash(hash); }
+ void GetHash(std::vector<uint8_t>* hash) const override { GetPkHash(hash); }
- virtual std::string GetName() const { return "Software Reporter Tool"; }
+ std::string GetName() const override { return "Software Reporter Tool"; }
static base::FilePath install_dir() {
// The base directory on windows looks like:
« no previous file with comments | « chrome/browser/chrome_select_file_dialog_factory_win.cc ('k') | chrome/browser/diagnostics/diagnostics_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698