Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1107963003: [chrome/browser/component_updater] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
waffles, Sorin Jianu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/component_updater BUG=466848 Committed: https://crrev.com/0bca2e5d904896ac593b5e447b98931faa717d80 Cr-Commit-Position: refs/heads/master@{#328489}

Patch Set 1 #

Patch Set 2 : Rebased the patch #

Messages

Total messages: 21 (10 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-04-29 07:38:30 UTC) #2
anujsharma
Sorin looks busy. @cpu: could you please take a look over the changes. Thank you!!
5 years, 7 months ago (2015-05-04 07:49:22 UTC) #4
cpu_(ooo_6.6-7.5)
I don't even know what those macros even do. Better reviewer selected.
5 years, 7 months ago (2015-05-05 21:07:30 UTC) #6
waffles
lgtm
5 years, 7 months ago (2015-05-05 21:45:02 UTC) #7
Sorin Jianu
lgtm Thank you, I apologize for not seeing and responding to the review in a ...
5 years, 7 months ago (2015-05-05 23:13:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107963003/1
5 years, 7 months ago (2015-05-06 01:46:31 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/49856) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-06 01:51:47 UTC) #15
anujsharma
On 2015/05/05 23:13:23, Sorin Jianu wrote: > lgtm > > Thank you, I apologize for ...
5 years, 7 months ago (2015-05-06 03:07:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107963003/20001
5 years, 7 months ago (2015-05-06 03:47:34 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-06 05:20:38 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 05:21:32 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bca2e5d904896ac593b5e447b98931faa717d80
Cr-Commit-Position: refs/heads/master@{#328489}

Powered by Google App Engine
This is Rietveld 408576698