chrome/browser/component_updater/swiftshader_component_installer.cc - Issue 1107963003: [chrome/browser/component_updater] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/swiftshader_component_installer.cc

Issue 1107963003: [chrome/browser/component_updater] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased the patch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/sw_reporter_installer_win.cc ('k') | chrome/browser/component_updater/widevine_cdm_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/swiftshader_component_installer.cc

diff --git a/chrome/browser/component_updater/swiftshader_component_installer.cc b/chrome/browser/component_updater/swiftshader_component_installer.cc

index 3848393f090cee71ed78be713a2e44b78e17ec19..34355ca726cbcb48141d74d05d133d47c1e39c50 100644

--- a/chrome/browser/component_updater/swiftshader_component_installer.cc

+++ b/chrome/browser/component_updater/swiftshader_component_installer.cc

@@ -92,7 +92,7 @@ bool GetLatestSwiftShaderDirectory(base::FilePath* result,

}

void RegisterSwiftShaderWithChrome(const base::FilePath& path) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

GpuDataManager::GetInstance()->RegisterSwiftShaderPath(path);

}

@@ -171,7 +171,7 @@ bool SwiftShaderComponentInstaller::Uninstall() {

void FinishSwiftShaderUpdateRegistration(ComponentUpdateService* cus,

const Version& version) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

update_client::CrxComponent swiftshader;

swiftshader.name = "Swift Shader";

@@ -204,7 +204,7 @@ void UpdateChecker::OnGpuInfoUpdate() {

gpu_data_manager->IsFeatureBlacklisted(gpu::GPU_FEATURE_TYPE_WEBGL) ||

gpu_data_manager->ShouldUseSwiftShader()) {

gpu_data_manager->RemoveObserver(this);

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

base::FilePath path = GetSwiftShaderBaseDirectory();

Version version(kNullVersion);

@@ -222,7 +222,7 @@ void UpdateChecker::OnGpuInfoUpdate() {

// Check if there already is a version of swiftshader installed,

// and if so register it.

void RegisterSwiftShaderPath(ComponentUpdateService* cus) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

base::FilePath path = GetSwiftShaderBaseDirectory();

if (!base::PathExists(path)) {

if (!base::CreateDirectory(path)) {