Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/component_updater/recovery_component_installer.cc

Issue 1107963003: [chrome/browser/component_updater] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased the patch Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/recovery_component_installer.cc
diff --git a/chrome/browser/component_updater/recovery_component_installer.cc b/chrome/browser/component_updater/recovery_component_installer.cc
index 4bd63a041d16fe32a4c72f7efa14ea5738b439ad..2563b103c3d256df62194efce880ff9ca1433ee5 100644
--- a/chrome/browser/component_updater/recovery_component_installer.cc
+++ b/chrome/browser/component_updater/recovery_component_installer.cc
@@ -203,7 +203,7 @@ void SimulateElevatedRecoveryHelper(PrefService* prefs) {
}
void RecoveryRegisterHelper(ComponentUpdateService* cus, PrefService* prefs) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
Version version(prefs->GetString(prefs::kRecoveryComponentVersion));
if (!version.IsValid()) {
NOTREACHED();
@@ -221,13 +221,13 @@ void RecoveryRegisterHelper(ComponentUpdateService* cus, PrefService* prefs) {
}
void RecoveryUpdateVersionHelper(const Version& version, PrefService* prefs) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
prefs->SetString(prefs::kRecoveryComponentVersion, version.GetString());
}
void SetPrefsForElevatedRecoveryInstall(const base::FilePath& unpack_path,
PrefService* prefs) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
prefs->SetFilePath(prefs::kRecoveryComponentUnpackPath, unpack_path);
prefs->SetBoolean(prefs::kRecoveryComponentNeedsElevation, true);
}
@@ -394,7 +394,7 @@ void RegisterPrefsForRecoveryComponent(PrefRegistrySimple* registry) {
}
void AcceptedElevatedRecoveryInstall(PrefService* prefs) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
#if defined(OS_WIN)
ElevatedInstallRecoveryComponent(
@@ -404,7 +404,7 @@ void AcceptedElevatedRecoveryInstall(PrefService* prefs) {
}
void DeclinedElevatedRecoveryInstall(PrefService* prefs) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
prefs->SetBoolean(prefs::kRecoveryComponentNeedsElevation, false);
}

Powered by Google App Engine
This is Rietveld 408576698