chrome/browser/component_updater/pnacl_component_installer.cc - Issue 1107963003: [chrome/browser/component_updater] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/pnacl_component_installer.cc

Issue 1107963003: [chrome/browser/component_updater] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased the patch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/pepper_flash_component_installer.cc ('k') | chrome/browser/component_updater/recovery_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/pnacl_component_installer.cc

diff --git a/chrome/browser/component_updater/pnacl_component_installer.cc b/chrome/browser/component_updater/pnacl_component_installer.cc

index 57d1475c16d6c73773461e76275668c575e14336..d9da41974111e0582b9674dceab3e66eadee5749 100644

--- a/chrome/browser/component_updater/pnacl_component_installer.cc

+++ b/chrome/browser/component_updater/pnacl_component_installer.cc

@@ -301,7 +301,7 @@ void FinishPnaclUpdateRegistration(

const Version& current_version,

const std::string& current_fingerprint,

const scoped_refptr<PnaclComponentInstaller>& pci) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

pci->set_current_version(current_version);

CheckVersionCompatiblity(current_version);

pci->set_current_fingerprint(current_fingerprint);

@@ -319,7 +319,7 @@ void FinishPnaclUpdateRegistration(

// a hosted version is actually newer.

void StartPnaclUpdateRegistration(

const scoped_refptr<PnaclComponentInstaller>& pci) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

base::FilePath path = pci->GetPnaclBaseDirectory();

if (!base::PathExists(path)) {

if (!base::CreateDirectory(path)) {