Issue 110693002: Add a canvas object with drawRect() and inval().

Issue 110693002: Add a canvas object with drawRect() and inval(). (Closed)

Created:
7 years ago by jcgregorio

Modified:
7 years ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Add a canvas object with drawRect() and inval(). BUG= Committed: http://code.google.com/p/skia/source/detail?r=12595

Patch Set 3 : Fix up code to Skia style. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+314 lines, -151 lines)			Patch
M	.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	experimental/SkV8Example/SkV8Example.h	View	1 2	1 chunk	+62 lines, -12 lines	0 comments	Download
M	experimental/SkV8Example/SkV8Example.cpp	View	1 2	2 chunks	+251 lines, -139 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + nits https://codereview.chromium.org/110693002/diff/20001/experimental/SkV8Example/SkV8Example.cpp File experimental/SkV8Example/SkV8Example.cpp (right): https://codereview.chromium.org/110693002/diff/20001/experimental/SkV8Example/SkV8Example.cpp#newcode115 experimental/SkV8Example/SkV8Example.cpp:115: Handle<ObjectTemplate> JsCanvas::MakeCanvasTemplate() { handleScope? https://codereview.chromium.org/110693002/diff/20001/experimental/SkV8Example/SkV8Example.cpp#newcode140 experimental/SkV8Example/SkV8Example.cpp:140: ...

7 years ago (2013-12-10 13:40:44 UTC) #2

jcgregorio

https://codereview.chromium.org/110693002/diff/20001/experimental/SkV8Example/SkV8Example.cpp File experimental/SkV8Example/SkV8Example.cpp (right): https://codereview.chromium.org/110693002/diff/20001/experimental/SkV8Example/SkV8Example.cpp#newcode115 experimental/SkV8Example/SkV8Example.cpp:115: Handle<ObjectTemplate> JsCanvas::MakeCanvasTemplate() { On 2013/12/10 13:40:44, robertphillips wrote: > ...

7 years ago (2013-12-10 14:00:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/110693002/40001

7 years ago (2013-12-10 14:00:12 UTC) #4

Message was sent while issue was closed.

Change committed as 12595

Expand Messages | Collapse Messages