[turbofan] Unify frame state inputs.

[turbofan] Unify frame state inputs.

Now all nodes that care about deoptimization always take frame state
inputs no matter whether deoptimization is enabled for a particular
function. In case that deoptimization is off, the AstGraphBuilder just
inserts the empty frame state. This greatly simplifies the logic in
various places and makes testing easier as well, and is probably the
first step towards enabling --turbo-deoptimization by default.

There seems to be no noticable performance impact on asm.js programs.

Also fix the graph replay in order to regenerate the scheduler unittests.

Committed: https://crrev.com/4940c0bd4250becfded9b366282479c0d42310d7
Cr-Commit-Position: refs/heads/master@{#28026}

[Benedikt Meurer, 2015-04-23 07:53:22]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org, mstarzinger@chromium.org

[Benedikt Meurer, 2015-04-23 07:53:22]

Jaro: PTAL
Michi: FYI

[Jarin, 2015-04-23 08:33:09]

lgtm. Great stuff, thanks for doing this!

https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-intrinsic-l...
File src/compiler/js-intrinsic-lowering.cc (right):

https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-intrinsic-l...
src/compiler/js-intrinsic-lowering.cc:162: // TODO(bmeurer): if
(!FLAG_turbo_deoptimization) return NoChange();
I think we should keep the check here, so that we do not crash on clusterfuzz.
(This basically means ignoring the deoptimization.)

https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:214: // TODO(bmeurer): if
(!FLAG_turbo_deoptimization) return nullptr;
Remove the TODO and perhaps consider short-circuiting for BailoutId::None (just
like the CreateFrameStateForRightInput method).

https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:237: // TODO(bmeurer): if
(!FLAG_turbo_deoptimization) return nullptr;
Remove the TODO.

[Benedikt Meurer, 2015-04-23 08:35:35]

https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-intrinsic-l...
File src/compiler/js-intrinsic-lowering.cc (right):

https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-intrinsic-l...
src/compiler/js-intrinsic-lowering.cc:162: // TODO(bmeurer): if
(!FLAG_turbo_deoptimization) return NoChange();
On 2015/04/23 08:33:08, jarin wrote:
> I think we should keep the check here, so that we do not crash on clusterfuzz.
> (This basically means ignoring the deoptimization.)

Done.

https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:214: // TODO(bmeurer): if
(!FLAG_turbo_deoptimization) return nullptr;
On 2015/04/23 08:33:08, jarin wrote:
> Remove the TODO and perhaps consider short-circuiting for BailoutId::None
(just
> like the CreateFrameStateForRightInput method).

Done.

https://codereview.chromium.org/1106613003/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:237: // TODO(bmeurer): if
(!FLAG_turbo_deoptimization) return nullptr;
On 2015/04/23 08:33:08, jarin wrote:
> Remove the TODO.

Done.

[Benedikt Meurer, 2015-04-23 08:35:39]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-04-23 08:35:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106613003/20001

[Benedikt Meurer, 2015-04-23 08:36:07]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2015-04-23 08:36:43]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-04-23 08:36:43]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1106613003/#ps40001
(title: "Address comment.")

[commit-bot: I haz the power, 2015-04-23 08:36:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106613003/40001

[commit-bot: I haz the power, 2015-04-23 09:04:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-23 09:04:57]

Patchset 3 (id:??) landed as
https://crrev.com/4940c0bd4250becfded9b366282479c0d42310d7
Cr-Commit-Position: refs/heads/master@{#28026}