Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 1106613003: [turbofan] Unify frame state inputs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/compiler/js-operator-unittest.cc ('k') | test/unittests/compiler/node-test-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-typed-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc
index c99d68bda3408660fffbc02167843650673b4efe..6ba205850b6211fd3beb31bc8c70e855f3ab26a3 100644
--- a/test/unittests/compiler/js-typed-lowering-unittest.cc
+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc
@@ -417,11 +417,8 @@ TEST_F(JSTypedLoweringTest, JSToNumberWithPlainPrimitive) {
Node* const effect = graph()->start();
Node* const control = graph()->start();
Reduction r =
- FLAG_turbo_deoptimization
- ? Reduce(graph()->NewNode(javascript()->ToNumber(), input, context,
- EmptyFrameState(), effect, control))
- : Reduce(graph()->NewNode(javascript()->ToNumber(), input, context,
- effect, control));
+ Reduce(graph()->NewNode(javascript()->ToNumber(), input, context,
+ EmptyFrameState(), effect, control));
ASSERT_TRUE(r.Changed());
EXPECT_THAT(r.replacement(), IsToNumber(input, IsNumberConstant(BitEq(0.0)),
graph()->start(), control));
@@ -639,14 +636,9 @@ TEST_F(JSTypedLoweringTest, JSLoadPropertyFromExternalTypedArray) {
Node* context = UndefinedConstant();
Node* effect = graph()->start();
Node* control = graph()->start();
- Node* node = graph()->NewNode(javascript()->LoadProperty(feedback), base,
- key, context);
- if (FLAG_turbo_deoptimization) {
- node->AppendInput(zone(), UndefinedConstant());
- }
- node->AppendInput(zone(), effect);
- node->AppendInput(zone(), control);
- Reduction r = Reduce(node);
+ Reduction r =
+ Reduce(graph()->NewNode(javascript()->LoadProperty(feedback), base, key,
+ context, EmptyFrameState(), effect, control));
Matcher<Node*> offset_matcher =
element_size == 1
@@ -685,14 +677,9 @@ TEST_F(JSTypedLoweringTest, JSLoadPropertyFromExternalTypedArrayWithSafeKey) {
Node* context = UndefinedConstant();
Node* effect = graph()->start();
Node* control = graph()->start();
- Node* node = graph()->NewNode(javascript()->LoadProperty(feedback), base,
- key, context);
- if (FLAG_turbo_deoptimization) {
- node->AppendInput(zone(), UndefinedConstant());
- }
- node->AppendInput(zone(), effect);
- node->AppendInput(zone(), control);
- Reduction r = Reduce(node);
+ Reduction r =
+ Reduce(graph()->NewNode(javascript()->LoadProperty(feedback), base, key,
+ context, EmptyFrameState(), effect, control));
ASSERT_TRUE(r.Changed());
EXPECT_THAT(
@@ -875,16 +862,11 @@ TEST_F(JSTypedLoweringTest, JSLoadNamedGlobalConstants) {
for (size_t i = 0; i < arraysize(names); i++) {
Unique<Name> name = Unique<Name>::CreateImmovable(names[i]);
- Node* node = graph()->NewNode(javascript()->LoadNamed(name, feedback),
- global, context);
- if (FLAG_turbo_deoptimization) {
- node->AppendInput(zone(), EmptyFrameState());
- }
- node->AppendInput(zone(), effect);
- node->AppendInput(zone(), control);
-
- Reduction r = Reduce(node);
+ Reduction r =
+ Reduce(graph()->NewNode(javascript()->LoadNamed(name, feedback), global,
+ context, EmptyFrameState(), effect, control));
+ ASSERT_TRUE(r.Changed());
EXPECT_THAT(r.replacement(), matches[i]);
}
}
« no previous file with comments | « test/unittests/compiler/js-operator-unittest.cc ('k') | test/unittests/compiler/node-test-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698