Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2158)

Unified Diff: test/unittests/compiler/js-intrinsic-lowering-unittest.cc

Issue 1106613003: [turbofan] Unify frame state inputs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/js-intrinsic-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-intrinsic-lowering-unittest.cc b/test/unittests/compiler/js-intrinsic-lowering-unittest.cc
index 33530f5188f434881f622df12e5b13705f7f767b..a9a59d5c04b063b17d3c319d61638f45b5abf24f 100644
--- a/test/unittests/compiler/js-intrinsic-lowering-unittest.cc
+++ b/test/unittests/compiler/js-intrinsic-lowering-unittest.cc
@@ -38,6 +38,12 @@ class JSIntrinsicLoweringTest : public GraphTest {
return reducer.Reduce(node);
}
+ Node* EmptyFrameState() {
+ MachineOperatorBuilder machine(zone());
+ JSGraph jsgraph(isolate(), graph(), common(), javascript(), &machine);
+ return jsgraph.EmptyFrameState();
+ }
+
JSOperatorBuilder* javascript() { return &javascript_; }
private:
@@ -71,23 +77,23 @@ TEST_F(JSIntrinsicLoweringTest, InlineOptimizedConstructDouble) {
TEST_F(JSIntrinsicLoweringTest, InlineCreateArrayLiteral) {
- i::FLAG_turbo_deoptimization = false;
Node* const input0 = Parameter(0);
Node* const input1 = Parameter(1);
Node* const input2 = HeapConstant(factory()->NewFixedArray(12));
Node* const input3 = NumberConstant(ArrayLiteral::kShallowElements);
Node* const context = Parameter(2);
+ Node* const frame_state = EmptyFrameState();
Node* const effect = graph()->start();
Node* const control = graph()->start();
Reduction const r = Reduce(graph()->NewNode(
javascript()->CallRuntime(Runtime::kInlineCreateArrayLiteral, 4), input0,
- input1, input2, input3, context, effect, control));
+ input1, input2, input3, context, frame_state, effect, control));
ASSERT_TRUE(r.Changed());
EXPECT_THAT(
r.replacement(),
IsCall(_, IsHeapConstant(Unique<HeapObject>::CreateImmovable(
CodeFactory::FastCloneShallowArray(isolate()).code())),
- input0, input1, input2, effect, control));
+ input0, input1, input2, context, frame_state, effect, control));
}
@@ -96,23 +102,24 @@ TEST_F(JSIntrinsicLoweringTest, InlineCreateArrayLiteral) {
TEST_F(JSIntrinsicLoweringTest, InlineCreateObjectLiteral) {
- i::FLAG_turbo_deoptimization = false;
Node* const input0 = Parameter(0);
Node* const input1 = Parameter(1);
Node* const input2 = HeapConstant(factory()->NewFixedArray(2 * 6));
Node* const input3 = NumberConstant(ObjectLiteral::kShallowProperties);
Node* const context = Parameter(2);
+ Node* const frame_state = EmptyFrameState();
Node* const effect = graph()->start();
Node* const control = graph()->start();
Reduction const r = Reduce(graph()->NewNode(
javascript()->CallRuntime(Runtime::kInlineCreateObjectLiteral, 4), input0,
- input1, input2, input3, context, effect, control));
+ input1, input2, input3, context, frame_state, effect, control));
ASSERT_TRUE(r.Changed());
EXPECT_THAT(
r.replacement(),
IsCall(_, IsHeapConstant(Unique<HeapObject>::CreateImmovable(
CodeFactory::FastCloneShallowObject(isolate(), 6).code())),
- input0, input1, input2, effect, control));
+ input0, input1, input2, input3, context, frame_state, effect,
+ control));
}
« no previous file with comments | « test/unittests/compiler/control-flow-optimizer-unittest.cc ('k') | test/unittests/compiler/js-operator-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698