[rac] Temporarily copy libaddressinput to Chrome.

[rac] Temporarily copy libaddressinput to Chrome.

This patch copies libaddressinput to Chrome to enable local development of
the library. After Chrome-specific changes are in, we will upstream the
library back to https://libaddressinput.googlecode.com.

BUG=327046
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239705

[please use gerrit instead, 2013-12-09 18:31:01]

Evan: PTAL.

I've moved the latest libaddressinput from src/third_party/libaddressinput/src/
to src/third_party/libaddressinput/chromium/.

I've described the required changes below. The rest of the patch is "new files"
(copies from the external repository).

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
File third_party/libaddressinput/README.chromium (right):

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
third_party/libaddressinput/README.chromium:19: validation logic, which will be
upstreamed back to libadddressinput.
Updated the revision number and mentioned upstreaming.

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
File third_party/libaddressinput/libaddressinput.gyp (right):

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
third_party/libaddressinput/libaddressinput.gyp:6: 'libaddressinput_dir':
'chromium',
Using a variable for easy switching between chromium/ and src/.

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
third_party/libaddressinput/libaddressinput.gyp:49: 'chromium/util/json.h',
Did not move Chrome-specific json.h and json.cc files. Moving them into
chromium/cpp/src/ will create definition conflicts. These file will remain here
also after upstreaming our changes.

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
third_party/libaddressinput/libaddressinput.gyp:79: '<(DEPTH)',
These include directories are required for compilation with the updated
libaddressinput_dir path.

https://codereview.chromium.org/110533002/diff/20001/tools/gritsettings/resou...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/110533002/diff/20001/tools/gritsettings/resou...
tools/gritsettings/resource_ids:203:
"third_party/libaddressinput/chromium/cpp/res/messages.grd": {
Changed the path of messages.grd from src/ to chromium/.

[Evan Stade, 2013-12-09 18:42:26]

LG, but could you also file a bug titled roughly "Remove Chrome's copy of
libaddressinput", give an explanation there of our plans and timelines
(upstreaming, etc.), and link to that bug in the README.chromium and in this CL
description?

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
File third_party/libaddressinput/README.chromium (right):

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
third_party/libaddressinput/README.chromium:19: validation logic, which will be
upstreamed back to libadddressinput.
nit: 3 ds in a row

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
third_party/libaddressinput/README.chromium:19: validation logic, which will be
upstreamed back to libadddressinput.
On 2013/12/09 18:31:01, Rouslan Solomakhin wrote:
> Updated the revision number and mentioned upstreaming.

Could you explain this in a little more detail? i.e.

"Chrome's fork of the libaddressinput C++ port is rooted at chromium/src." and
link to the bug you file?

[please use gerrit instead, 2013-12-09 19:06:12]

Evan: PTAL Patch Set 2 and the updated patch description.

[please use gerrit instead, 2013-12-09 19:11:22]

Evan: PTAL Patch Set 4. I've addressed the rest of your comments.

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
File third_party/libaddressinput/README.chromium (right):

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
third_party/libaddressinput/README.chromium:19: validation logic, which will be
upstreamed back to libadddressinput.
On 2013/12/09 18:42:26, Evan Stade wrote:
> nit: 3 ds in a row

Done.

https://codereview.chromium.org/110533002/diff/20001/third_party/libaddressin...
third_party/libaddressinput/README.chromium:19: validation logic, which will be
upstreamed back to libadddressinput.
On 2013/12/09 18:42:26, Evan Stade wrote:
> On 2013/12/09 18:31:01, Rouslan Solomakhin wrote:
> > Updated the revision number and mentioned upstreaming.
> 
> Could you explain this in a little more detail? i.e.
> 
> "Chrome's fork of the libaddressinput C++ port is rooted at chromium/src." and
> link to the bug you file?

Done.

[Evan Stade, 2013-12-09 19:16:56]

lgtm

https://codereview.chromium.org/110533002/diff/50001/third_party/libaddressin...
File third_party/libaddressinput/README.chromium (right):

https://codereview.chromium.org/110533002/diff/50001/third_party/libaddressin...
third_party/libaddressinput/README.chromium:20: (http://crbug.com/327046). The
Chrome-specific version is in chromium/
nit: there's stuff in chromium/ not part of libaddressinput/not planning to be
usptreamed

[please use gerrit instead, 2013-12-09 19:20:48]

Sending to CQ.

https://codereview.chromium.org/110533002/diff/50001/third_party/libaddressin...
File third_party/libaddressinput/README.chromium (right):

https://codereview.chromium.org/110533002/diff/50001/third_party/libaddressin...
third_party/libaddressinput/README.chromium:20: (http://crbug.com/327046). The
Chrome-specific version is in chromium/
On 2013/12/09 19:16:57, Evan Stade wrote:
> nit: there's stuff in chromium/ not part of libaddressinput/not planning to be
> usptreamed

Changed to chromium/cpp/.

[commit-bot: I haz the power, 2013-12-09 19:41:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/110533002/60001

[commit-bot: I haz the power, 2013-12-09 22:40:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/110533002/80001

[commit-bot: I haz the power, 2013-12-10 07:45:31]

Change committed as 239705