third_party/libaddressinput/README.chromium - Issue 110533002: [rac] Temporarily copy libaddressinput to Chrome.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libaddressinput/README.chromium

Issue 110533002: [rac] Temporarily copy libaddressinput to Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 Name: The library to input and validate addresses.	1 Name: The library to input and validate addresses.

2 Short Name: libaddressinput	2 Short Name: libaddressinput

3 URL: https://code.google.com/p/libaddressinput/	3 URL: https://code.google.com/p/libaddressinput/

4 Version: 0	4 Version: 0

5 Date: 16 October 2013	5 Date: 5 December 2013

6 Revision: 146	6 Revision: 176

7 License: Apache 2.0	7 License: Apache 2.0

8 License File: LICENSE	8 License File: LICENSE

9 Security Critical: no	9 Security Critical: no

10	10

11 Description:	11 Description:

12 This library allows users to input their address, and perform validation on this	12 This library allows users to input their address, and perform validation on this

13 by talking to an address data server at https://i18napis.appspot.com/address.	13 by talking to an address data server https://i18napis.appspot.com/ssl-address.

14 The library is used in requestAutocomplete() dialog to enable internationalized	14 The library is used in requestAutocomplete() dialog to enable internationalized

15 address input and validation for payment forms.	15 address input and validation for payment forms.

16	16

17 Local Modifications:	17 Local Modifications:

18 The package has no local modifications.	18 The package is libaddressinput at revision 176 plus the Chrome-specific

	19 validation logic, which will be upstreamed back to libadddressinput.
	please use gerrit instead 2013/12/09 18:31:01 Updated the revision number and mentioned upstream Updated the revision number and mentioned upstreaming. Evan Stade 2013/12/09 18:42:26 nit: 3 ds in a row nit: 3 ds in a row Evan Stade 2013/12/09 18:42:26 Could you explain this in a little more detail? i. Show quoted text On 2013/12/09 18:31:01, Rouslan Solomakhin wrote: > Updated the revision number and mentioned upstreaming. Could you explain this in a little more detail? i.e. "Chrome's fork of the libaddressinput C++ port is rooted at chromium/src." and link to the bug you file? please use gerrit instead 2013/12/09 19:11:22 Done. Show quoted text On 2013/12/09 18:42:26, Evan Stade wrote: > nit: 3 ds in a row Done. please use gerrit instead 2013/12/09 19:11:22 Done. Show quoted text On 2013/12/09 18:42:26, Evan Stade wrote: > On 2013/12/09 18:31:01, Rouslan Solomakhin wrote: > > Updated the revision number and mentioned upstreaming. > > Could you explain this in a little more detail? i.e. > > "Chrome's fork of the libaddressinput C++ port is rooted at chromium/src." and > link to the bug you file? Done.
OLD	NEW

« no previous file with comments | « no previous file | third_party/libaddressinput/chromium/cpp/LICENSE.chromium » ('j') | third_party/libaddressinput/libaddressinput.gyp » ('J')