Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 1105263002: Remove vertex/index buffer factilities from GrDrawTarget. (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@josh
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove vertex/index buffer factilities from GrDrawTarget. Committed: https://skia.googlesource.com/skia/+/72e3ae486c66871c2043eac4f08d85d419fbca2a

Patch Set 1 #

Patch Set 2 : update #

Total comments: 1

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1303 lines) Patch
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 5 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/GrContext.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 11 chunks +11 lines, -384 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 4 chunks +0 lines, -529 lines 0 comments Download
M src/gpu/GrFlushToGpuDrawTarget.h View 1 2 chunks +1 line, -37 lines 0 comments Download
M src/gpu/GrFlushToGpuDrawTarget.cpp View 3 chunks +0 lines, -196 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 4 chunks +0 lines, -24 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 2 chunks +0 lines, -17 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 12 chunks +0 lines, -96 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrTest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrTestBatch.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bsalomon
5 years, 7 months ago (2015-04-28 14:19:57 UTC) #2
joshualitt
lgtm https://codereview.chromium.org/1105263002/diff/20001/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (left): https://codereview.chromium.org/1105263002/diff/20001/src/gpu/GrDrawTarget.cpp#oldcode309 src/gpu/GrDrawTarget.cpp:309: int indexCount) const { I think we should ...
5 years, 7 months ago (2015-04-28 14:32:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105263002/40001
5 years, 7 months ago (2015-04-28 14:53:55 UTC) #6
bsalomon
On 2015/04/28 14:32:15, joshualitt wrote: > lgtm > > https://codereview.chromium.org/1105263002/diff/20001/src/gpu/GrDrawTarget.cpp > File src/gpu/GrDrawTarget.cpp (left): > ...
5 years, 7 months ago (2015-04-28 14:53:56 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 15:08:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/72e3ae486c66871c2043eac4f08d85d419fbca2a

Powered by Google App Engine
This is Rietveld 408576698