[Invalidations] Require there to be no registered handlers on Invalidator destruction

[Invalidations] Require there to be no registered handlers on Invalidator destruction

Add CHECK to catch sloppy clients.

Make ProfileSyncService destroy its invalidator registrar on shut down (also to catch
sloppy clients).  Comment on expected usage of Initialize() and Shutdown(),
and add DCHECKs for them.

Fix Invalidator test template to unregister handlers properly.  Also fix some ProfileSyncService tests.

BUG=137086
TBR=tim@chromium.org,arv@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160420

[akalin, 2012-10-02 21:59:00]

+zea for review

[akalin, 2012-10-03 18:03:11]

On 2012/10/02 21:59:00, akalin wrote:
> +zea for review

Hold off on this, I guess.  Push messaging breaks this.

[akalin, 2012-10-03 18:42:42]

Okay, rebased on http://codereview.chromium.org/11046008/ which should fix the
integration test failures.

Ready for review!

[Nicolas Zea, 2012-10-03 22:51:27]

Looks like syncsetuphandler's unit test is breaking still?

[akalin, 2012-10-04 00:05:33]

Okay, I fixed those, PTAL.

[Nicolas Zea, 2012-10-04 00:10:26]

lgtm

[commit-bot: I haz the power, 2012-10-05 06:57:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/11046008/30006

[commit-bot: I haz the power, 2012-10-05 06:57:07]

Presubmit check for 11046008-30006 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/webui
    chrome/browser/signin

Presubmit checks took 2.8s to calculate.

[akalin, 2012-10-05 16:05:34]

TBRing tim, arv

[commit-bot: I haz the power, 2012-10-05 16:05:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/11046008/30006

[commit-bot: I haz the power, 2012-10-05 17:34:02]

Retried try job too often for step(s) interactive_ui_tests