[Invalidations] Require there to be no registered handlers on Invalidator destruction

sync/notifier/invalidator_registrar_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "google/cacheinvalidation/types.pb.h"
 #include "sync/notifier/fake_invalidation_handler.h"
 #include "sync/notifier/invalidator_registrar.h"
@@ skipping 106 matching lines @@
  private:
   scoped_ptr<RegistrarInvalidator> invalidator_;
 };
 
 INSTANTIATE_TYPED_TEST_CASE_P(
     RegistrarInvalidatorTest, InvalidatorTest,
     RegistrarInvalidatorTestDelegate);
 
 class InvalidatorRegistrarTest : public testing::Test {};
 
+// Technically the tests below can be part of InvalidatorTest, but we
+// want to keep the number of death tests down.
+
+// When we expect a death via CHECK(), we can't match against the
+// CHECK() message since they are removed in official builds.
+
+// Having registered handlers on destruction should cause a CHECK.
+TEST_F(InvalidatorRegistrarTest, RegisteredHandlerOnDestruction) {
+  scoped_ptr<InvalidatorRegistrar> registrar(new InvalidatorRegistrar());
+  FakeInvalidationHandler handler;
+
+  registrar->RegisterHandler(&handler);
+
+  EXPECT_DEATH({ registrar.reset(); }, "");
+
+  ASSERT_TRUE(registrar.get());
+  registrar->UnregisterHandler(&handler);
+}
+
 // Multiple registrations by different handlers on the same object ID should
 // cause a CHECK.
-//
-// Technically this can be part of InvalidatorTest, but we want to keep the
-// number of death tests down.
 TEST_F(InvalidatorRegistrarTest, MultipleRegistration) {
   const invalidation::ObjectId id1(ipc::invalidation::ObjectSource::TEST, "a");
   const invalidation::ObjectId id2(ipc::invalidation::ObjectSource::TEST, "a");
 
   InvalidatorRegistrar registrar;
 
   FakeInvalidationHandler handler1;
   registrar.RegisterHandler(&handler1);
 
   FakeInvalidationHandler handler2;
   registrar.RegisterHandler(&handler2);
 
   ObjectIdSet ids;
   ids.insert(id1);
   ids.insert(id2);
   registrar.UpdateRegisteredIds(&handler1, ids);
 
   registrar.DetachFromThreadForTest();
-  // We expect a death via CHECK(). We can't match against the CHECK() message
-  // though since they are removed in official builds.
   EXPECT_DEATH({ registrar.UpdateRegisteredIds(&handler2, ids); }, "");
+
+  registrar.UnregisterHandler(&handler2);
+  registrar.UnregisterHandler(&handler1);
 }
 
 }  // namespace
 
 }  // namespace syncer