sync/notifier/invalidator_registrar.cc - Issue 11046008: [Invalidations] Require there to be no registered handlers on Invalidator destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/notifier/invalidator_registrar.cc

Issue 11046008: [Invalidations] Require there to be no registered handlers on Invalidator destruction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Sync to HEAD Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/notifier/invalidator_registrar.cc

diff --git a/sync/notifier/invalidator_registrar.cc b/sync/notifier/invalidator_registrar.cc

index 1fb6571ae8436477f825a1b4dd5495d4a5c4fcba..0c8d0f74392b100d2f4c0c51bd3d567977fbeeaf 100644

--- a/sync/notifier/invalidator_registrar.cc

+++ b/sync/notifier/invalidator_registrar.cc

@@ -16,6 +16,8 @@ InvalidatorRegistrar::InvalidatorRegistrar()

InvalidatorRegistrar::~InvalidatorRegistrar() {

DCHECK(thread_checker_.CalledOnValidThread());

+ CHECK(!handlers_.might_have_observers());

+ // |id_to_handler_map_| may be non-empty but that's okay.

}

void InvalidatorRegistrar::RegisterHandler(InvalidationHandler* handler) {

« no previous file with comments | « sync/notifier/invalidator_registrar.h ('k') | sync/notifier/invalidator_registrar_unittest.cc » ('j') | no next file with comments »