Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: sync/notifier/invalidator.h

Issue 11046008: [Invalidations] Require there to be no registered handlers on Invalidator destruction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to HEAD Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/sync_setup_handler_unittest.cc ('k') | sync/notifier/invalidator_registrar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/notifier/invalidator.h
diff --git a/sync/notifier/invalidator.h b/sync/notifier/invalidator.h
index cd5c289f970a4e9517299a5cd37c8bab4f6acac7..4aa5d70543a62dbec70ef91997b6d2b2328dda34 100644
--- a/sync/notifier/invalidator.h
+++ b/sync/notifier/invalidator.h
@@ -48,6 +48,10 @@ class Invalidator {
//
// invalidator->UpdateRegisteredIds(client_handler, ObjectIdSet());
// invalidator->UnregisterHandler(client_handler);
+ //
+ // It is an error to have registered handlers when an invalidator is
+ // destroyed; clients must ensure that they unregister themselves
+ // before then.
// Starts sending notifications to |handler|. |handler| must not be NULL,
// and it must not already be registered.
« no previous file with comments | « chrome/browser/ui/webui/sync_setup_handler_unittest.cc ('k') | sync/notifier/invalidator_registrar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698