Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1100843003: WebMidi: use testRunner.setPermission in addition of .setMIDISysexPermission. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

WebMidi: use testRunner.setPermission in addition of .setMIDISysexPermission. This is a transition CL to allow Chromium to stop supporting the setMIDISysexPermission call. This CL is part of a suite of four patches: Part 1: <this> Part 2: https://codereview.chromium.org/1100673004 Part 3: https://codereview.chromium.org/1097933006 Part 4: https://codereview.chromium.org/1095233005 BUG=475141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M LayoutTests/webmidi/permission.html View 3 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/webmidi/permission-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webmidi/send-messages.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/webmidi/send-messages-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mlamouri (slow - plz ping)
Mike, PTAL.
5 years, 8 months ago (2015-04-22 14:41:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100843003/1
5 years, 8 months ago (2015-04-22 14:51:14 UTC) #4
Mike West
LGTM.
5 years, 8 months ago (2015-04-22 15:14:11 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/60328)
5 years, 8 months ago (2015-04-22 22:17:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100843003/1
5 years, 8 months ago (2015-04-22 22:21:58 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 23:20:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194247

Powered by Google App Engine
This is Rietveld 408576698