Issue 1097933006: WebMidi: stop using testRunner.setMIDISysexPermision and remove ClientMock.

Issue 1097933006: WebMidi: stop using testRunner.setMIDISysexPermision and remove ClientMock. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)

Modified:
5 years, 8 months ago

Reviewers:
Mike West

CC:
blink-reviews, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@midi_testrunner_setpermission

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

WebMidi: stop using testRunner.setMIDISysexPermision and remove ClientMock. The WebMidiClientMock is no longer used by Chromium. It was only used for permissions mocking and the testRunner has now a generic way to handle this. This CL is part of a suite of four patches: Part 1: https://codereview.chromium.org/1100843003 Part 2: https://codereview.chromium.org/1100673004 Part 3: <this> Part 4: https://codereview.chromium.org/1095233005 BUG=475141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194288

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -264 lines)			Patch
M	LayoutTests/webmidi/permission.html	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	LayoutTests/webmidi/permission-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/webmidi/send-messages.html	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/webmidi/send-messages-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/modules.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	Source/modules/webmidi/MIDIClientMock.h	View	1 chunk	+0 lines, -58 lines	0 comments	Download
D	Source/modules/webmidi/MIDIClientMock.cpp	View	1 chunk	+0 lines, -66 lines	0 comments	Download
D	Source/web/WebMIDIClientMock.cpp	View	1 chunk	+0 lines, -70 lines	0 comments	Download
M	Source/web/web.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	public/web/WebMIDIClientMock.h	View	1 chunk	+0 lines, -60 lines	0 comments	Download

Total messages: 6 (2 generated)

mlamouri (slow - plz ping)

Mike, I've heard you like file removals too :)

5 years, 8 months ago (2015-04-22 14:42:38 UTC) #2

Mike West

Those are the best! The only thing better is directory removals. How about //chrome? LGTM.

5 years, 8 months ago (2015-04-22 15:14:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097933006/1

5 years, 8 months ago (2015-04-23 11:02:39 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-23 12:13:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194288