Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1095233005: Remove TestRunner.SetMIDISysexPermission shell. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_midiclientmock
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TestRunner.SetMIDISysexPermission shell. This CL is part of a suite of four patches: Part 1: https://codereview.chromium.org/1100843003 Part 2: https://codereview.chromium.org/1100673004 Part 3: https://codereview.chromium.org/1097933006 Part 4: <this> BUG=475141 Committed: https://crrev.com/5737dedff41bae1065211e7668032f7dedb7f0ec Cr-Commit-Position: refs/heads/master@{#326619}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/shell/renderer/test_runner/test_runner.cc View 1 2 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mlamouri (slow - plz ping)
5 years, 8 months ago (2015-04-22 17:34:09 UTC) #2
Mike West
LGTM, but the CL description is incorrect (this is patch #4, right?)
5 years, 8 months ago (2015-04-23 08:49:41 UTC) #3
mlamouri (slow - plz ping)
On 2015/04/23 at 08:49:41, mkwst wrote: > LGTM, but the CL description is incorrect (this ...
5 years, 8 months ago (2015-04-23 10:42:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095233005/20001
5 years, 8 months ago (2015-04-23 15:38:21 UTC) #6
commit-bot: I haz the power
Failed to apply patch for content/shell/renderer/test_runner/test_runner.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-04-23 16:12:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095233005/40001
5 years, 8 months ago (2015-04-23 19:24:31 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-23 20:08:02 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 20:08:46 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5737dedff41bae1065211e7668032f7dedb7f0ec
Cr-Commit-Position: refs/heads/master@{#326619}

Powered by Google App Engine
This is Rietveld 408576698